Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixing crash when no data returned in SAPRFCV2 #887

Merged
merged 2 commits into from
Apr 5, 2024
Merged

🐛 Fixing crash when no data returned in SAPRFCV2 #887

merged 2 commits into from
Apr 5, 2024

Conversation

marcinpurtak
Copy link
Collaborator

@marcinpurtak marcinpurtak commented Apr 5, 2024 •
edited
Loading

Summary

Small fix to prevent partitioned queries from crashing when there is no data to return from SAP

Importance

Fixing issue #886

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@marcinpurtak marcinpurtak requested a review from m-paz April 5, 2024 09:28
@m-paz m-paz merged commit 198658a into 2.0 Apr 5, 2024
2 of 3 checks passed
@m-paz m-paz deleted the bug/886-saprfcv2-crashing-when-no-data-returned branch April 5, 2024 12:16
@trymzet trymzet mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-paz m-paz m-paz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcinpurtak @m-paz