Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharepoint handle null values #931

Merged
merged 10 commits into from
Jun 20, 2024
Merged

Sharepoint handle null values #931

merged 10 commits into from
Jun 20, 2024

Conversation

Rafalz13
Copy link
Contributor

@Rafalz13 Rafalz13 commented Jun 18, 2024

Summary

Added list of na_values. NA value is out of the list to treat NA as a string value.
Changed the way of casting column to string to be able to generate NaN instead of nan string values.

Importance

The change was needed to handle NaN values after casting to string. In the current version all values (including nan) are converted to string.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@Rafalz13 Rafalz13 added bug Something isn't working enhancement New feature or request labels Jun 18, 2024
@Rafalz13 Rafalz13 self-assigned this Jun 18, 2024
@Rafalz13 Rafalz13 requested review from m-paz and trymzet June 18, 2024 14:34
@Rafalz13
Copy link
Contributor Author

The change is tested using separate docker images.

@trymzet trymzet merged commit fb52bbe into 2.0 Jun 20, 2024
3 checks passed
@trymzet trymzet deleted the sharepoint_handle_null_values branch June 20, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants