[Config #135] create new file #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JGreenlee
reviewed
Jan 29, 2025
configs/la_mwphaseii.nrel-op.json
Outdated
Comment on lines
84
to
87
There was a problem hiding this comment.
@mbrozen I noticed some of these are @ucla.edu and some are @g.ucla.edu. Does it make a difference?
configs/la_mwphaseii.nrel-op.json
Outdated
| @@ -0,0 +1,90 @@ | |||
| { | |||
| "url_abbreviation": "la_mwphaseii", | |||
There was a problem hiding this comment.
Suggested change
| "url_abbreviation": "la_mwphaseii", | |
| "url_abbreviation": "la-mw-ii", |
configs/la_mwphaseii.nrel-op.json
Outdated
| "version": 1, | ||
| "ts": 1733961166568, | ||
| "server": { | ||
| "connectUrl": "https://la_mwphaseii-openpath.nrel.gov/api/", |
There was a problem hiding this comment.
Suggested change
| "connectUrl": "https://la_mwphaseii-openpath.nrel.gov/api/", | |
| "connectUrl": "https://la-mw-ii-openpath.nrel.gov/api/", |
|
No - sorry for the inconsistency. Both work but for consistency, can use
the ***@***.***
…----
Madeline Brozen (Maddie, she/her)
Deputy Director, Lewis Center for Regional Policy Studies
UCLA Luskin School of Public Affairs
Book a meeting with me <https://calendly.com/mbrozen-g>
On Wed, Jan 29, 2025 at 1:41 PM Jack Greenlee ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In configs/la_mwphaseii.nrel-op.json
<#136 (comment)>
:
> + ***@***.***",
+ ***@***.***",
+ ***@***.***",
+ ***@***.***"
@mbrozen <https://github.com/mbrozen> I noticed some of these are @
ucla.edu and some are @g.ucla.edu. Does it make a difference?
------------------------------
In configs/la_mwphaseii.nrel-op.json
<#136 (comment)>
:
> @@ -0,0 +1,90 @@
+{
+ "url_abbreviation": "la_mwphaseii",
⬇️ Suggested change
- "url_abbreviation": "la_mwphaseii",
+ "url_abbreviation": "la-mw-ii",
------------------------------
In configs/la_mwphaseii.nrel-op.json
<#136 (comment)>
:
> @@ -0,0 +1,90 @@
+{
+ "url_abbreviation": "la_mwphaseii",
+ "version": 1,
+ "ts": 1733961166568,
+ "server": {
+ "connectUrl": "https://la_mwphaseii-openpath.nrel.gov/api/",
⬇️ Suggested change
- "connectUrl": "https://la_mwphaseii-openpath.nrel.gov/api/",
+ "connectUrl": "https://la-mw-ii-openpath.nrel.gov/api/",
—
Reply to this email directly, view it on GitHub
<#136 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARGDMDQIUFLXWJCLWF3ULZ32NFDJRAVCNFSM6AAAAABTOS65JKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBSGQYTOMJYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new config file