fix typos and string/bool issues with admin_dashboard.token_generate
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was meeting with sm-ebike, I saw that their admin dashboard had the Tokens page enabled. To my surprise, I looked at their config and saw `"token_generate": "false"` Then I realized it should be `false` with no quotes. A string containing the word `"false"` evaluates as a truthy value and causes the Tokens page to show up. Looking further I realized there's actually 2 issues going on here. A lot of other programs have it misspelled as toekn_generate, which is because of a typo in parse-issue-body.js In parse-issue-body.js I fixed both the typo and the string/boolean mixup, then I manually fixed all the affected configs.
JGreenlee
force-pushed
the
fix-token-generate
branch
from
d150fdd to
a3ca2e1
Compare
Abby-Wheelis
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Thank you for catching this!
I was confused at first by the transition from combinedObject.autogen to configObject['opcode']['autogen'], but after looking into it I think it makes a lot of sense to refer to the established variable, which is already cleaned, to lock down that autogen = token_generate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was meeting with sm-ebike, I saw that their admin dashboard had the Tokens page enabled. To my surprise, I looked at their config and saw
"token_generate": "false"Then I realized it should be
falsewith no quotes. A string containing the word"false"evaluates as a truthy value, causing the Tokens page to show up.Looking further I realized there are actually 2 issues going on here. A lot of other programs have it misspelled as
toekn_generate, which is because of a typo inparse-issue-body.jsSo in
parse-issue-body.jsI fixed both the typo and the string/boolean mixup, then I manually fixed all the affected configs.