Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pouchdb-migrate has an unnecessary dependency on pouchdb #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lbeschastny
Copy link

@lbeschastny lbeschastny commented Dec 16, 2017

pouchdb-migrate should not depend on pouchdb itself. Especially since pouchdb is just on of many PouchDB builds obtained from pouchdb-core package and some plugins.

Right now pouchdb-migrate depend on pouchdb package in two ways.

First, it uses 'pouchdb/extras/promise', which was moves into a separate package pouchdb-promise. This package should be used instead.

Second, it's used in tests. But for this purpose pouchdb could be moved to devDependencies section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant