Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for enum values in field descriptors. #127

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Add support for enum values in field descriptors. #127

merged 1 commit into from
Feb 10, 2020

Conversation

thowimmer
Copy link
Contributor

This PR adds support for documenting enum values in the generated schema.
See #87 (comment)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.046% when pulling 43e31c1 on thowimmer:feature/87-support-for-enum-fields into 145ab87 on ePages-de:master.

@ozscheyge ozscheyge self-assigned this Feb 10, 2020
ozscheyge
ozscheyge approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@ozscheyge ozscheyge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution, thank you!

@ozscheyge ozscheyge merged commit 21213ef into ePages-de:master Feb 10, 2020
@thowimmer thowimmer mentioned this pull request Mar 4, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozscheyge ozscheyge ozscheyge approved these changes

@mduesterhoeft mduesterhoeft Awaiting requested review from mduesterhoeft

Assignees

@ozscheyge ozscheyge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thowimmer @coveralls @ozscheyge