Error when chunk coordinates are invalid

icechunk/src/format/snapshot.rs

@@ -16,7 +16,7 @@ use crate::metadata::{
 use super::{
     format_constants, manifest::ManifestRef, AttributesId, IcechunkFormatError,
     IcechunkFormatVersion, IcechunkResult, ManifestId, NodeId, ObjectId, Path,
-    SnapshotId, TableOffset,
+    SnapshotId, TableOffset, ChunkIndices
 };
 
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
@@ -49,6 +49,55 @@ pub struct ZarrArrayMetadata {
     pub dimension_names: Option<DimensionNames>,
 }
 
+impl ZarrArrayMetadata {
+
+    /// Returns an iterator over the maximum permitted chunk indices for the array.
+    ///
+    /// This function calculates the maximum chunk indices based on the shape of the array
+    /// and the chunk shape.
+    ///
+    /// # Returns
+    ///
+    /// An iterator over the maximum permitted chunk indices.
+    fn max_chunk_indices_permitted(&self) -> impl Iterator<Item = u64> + '_ {
+        self.shape
+            .iter()
+            .zip(self.chunk_shape.0.iter())
+            .map(|(s, cs)| ((s + cs.get() - 1)) / cs.get() - 1)
+    }
+
+    /// Validates the provided chunk coordinates for the array.
+    ///
+    /// This function checks if the provided chunk indices are valid for the array.
+    ///
+    /// # Arguments
+    ///
+    /// * `coord` - The chunk indices to validate.
+    ///
+    /// # Returns
+    ///
+    /// An `IcechunkResult` indicating whether the chunk coordinates are valid.
+    ///
+    /// # Errors
+    ///
+    /// Returns `IcechunkFormatError::ChunkCoordinatesNotFound` if the chunk coordinates are invalid.
+    pub fn valid_chunk_coord(&self, coord: &ChunkIndices) -> IcechunkResult<bool> {
+
+        let valid: bool = coord
+                    .0
+                    .iter()
+                    .zip(self.max_chunk_indices_permitted())
+                    .all(|(index, index_permitted)| *index <= index_permitted as u32);
+
+        if valid {
+            Ok(true)
+        } else {
+            Err(IcechunkFormatError::ChunkCoordinatesNotFound { coords: (coord.clone()) })
+        }
+
+    }
+}
+
 #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
 pub enum NodeData {
     Array(ZarrArrayMetadata, Vec<ManifestRef>),

icechunk/src/repository.rs

@@ -424,9 +424,20 @@ impl Repository {
         coord: ChunkIndices,
         data: Option<ChunkPayload>,
     ) -> RepositoryResult<()> {
-        self.get_array(&path)
-            .await
-            .map(|node| self.change_set.set_chunk_ref(node.id, coord, data))
+
+        let node_snapshot = self.get_array(&path).await?;
+
+        if let NodeData::Array(zarr_metadata, _, ) = node_snapshot.node_data {
+            zarr_metadata.valid_chunk_coord(&coord)?;
+            self.change_set.set_chunk_ref(node_snapshot.id, coord, data);  
+            Ok(())         
+        } else {
+            Err(RepositoryError::NotAnArray {
+                node: node_snapshot,
+                message: "getting an array".to_string(),
+            })
+        }
+
     }
 
     pub async fn get_node(&self, path: &Path) -> RepositoryResult<NodeSnapshot> {