-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adriannaluger NCEI submission #276
Conversation
Getting changes from main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good morning Adrianna,
Everything looks good...The site loads up and the plot is there. The only thing you forgot was to update your 'Site Info' to NY. Other than that it looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Adri! Agreed on a quick update of the Site Info, and it will be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updates my site info (hopefully successfully).
Hey Adrianna--It looks like your site information for your 'Temperature over time in New York' page is still set for LA. |
Sorry, I am having troubles updating it. Ill let you know when I have it figured out. |
Alright, everything should be good now! Let me know if it shows the updates on your end as well. @misterskye |
getting changes from main
Beautiful!!!! |
@eculler complete :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Adriannaluger , this looks fantastic! And I like your headline.
The next step to improving this as a portfolio page or blog post in my opinion would be to take a look at your Site Information. You mention inequality here, which I think could be very relevant to temperature rise, but you don't make that connection for the reader.
You could also consider using headline-style headers for your text as well as your plot, rather than a description of what is in the section (e.g. "A century of temperature data in New York highlights long-term changes" instead of "Data Source")
No description provided.