Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust OSM-based synthetic geolocation fields for micro-regions #56

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

amotl
Copy link
Member

@amotl amotl commented Dec 17, 2022

Some adjustments as a followup to #52. See also https://community.panodata.org/t/luftdatenpumpe-aiming-to-focus-on-sensor-id-instead-of-station-id/254/11 ff.

Field:   district_postcode_city_sensorid
Format:  District, Postcode City (#SensorID)
Example: Regierungsbezirk Darmstadt, 60385 Frankfurt (#76777)

Field:   suburb_postcode_city_sensorid
Format:  Suburb, Postcode City (#SensorID)
Example: Eckenheim, 60435 Frankfurt (#65567)

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Base: 55.89% // Head: 55.89% // No change to project coverage 👍

Coverage data is based on head (2fc1faf) compared to base (afe9da5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   55.89%   55.89%           
=======================================
  Files           3        3           
  Lines         297      297           
=======================================
  Hits          166      166           
  Misses        131      131           
Flag Coverage Δ
unittests 55.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amotl amotl marked this pull request as ready for review December 17, 2022 21:19
Field:   district_postcode_city_sensorid
Format:  District, Postcode City (#SensorID)
Example: Regierungsbezirk Darmstadt, 60385 Frankfurt (#76777)

Field:   suburb_postcode_city_sensorid
Format:  Suburb, Postcode City (#SensorID)
Example: Eckenheim, 60435 Frankfurt (#65567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant