Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "fsspec>=2021.6.0" work #492

Merged
merged 3 commits into from
Aug 14, 2021
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Aug 10, 2021

Hi there,

this is coming from the problem report #243 (comment) about the patch #431, which has problems when using fsspec>=2021.6.0, making the test suite croak.

This patch evaluates different ways to harmonize the machinery.

  1. Upgrade to fsspec==2021.7.0. (0a3e854)
  2. Use fsspec's find() method instead of glob(). (2cb4cae)
  3. Fix exception handling when requesting 404 resources using fsspec. (6e2adc6)

All of those improvements got suggested by @gutzbenj, thanks a stack!

With kind regards,
Andreas.

@amotl amotl changed the title Make FSSPEC work by downgrading to requests==2.25.1 Make "fsspec" work by downgrading to "requests==2.25.1" Aug 10, 2021
@amotl amotl force-pushed the collab/fsspec-most-recent branch from 132a056 to 1f0eda6 Compare August 10, 2021 20:13
@amotl amotl changed the title Make "fsspec" work by downgrading to "requests==2.25.1" Evaluate ways to make "fsspec>=2021.6.0" work Aug 10, 2021
@amotl amotl requested a review from gutzbenj August 10, 2021 21:20
@amotl amotl marked this pull request as ready for review August 10, 2021 21:20
@amotl amotl changed the title Evaluate ways to make "fsspec>=2021.6.0" work Make "fsspec>=2021.6.0" work Aug 10, 2021
@amotl amotl force-pushed the collab/fsspec-most-recent branch 3 times, most recently from 7ad17b2 to 760c761 Compare August 12, 2021 10:55
@amotl amotl force-pushed the collab/fsspec-most-recent branch from 760c761 to 6979866 Compare August 12, 2021 15:54
@amotl amotl merged commit 8665741 into collab/fsspec Aug 14, 2021
@amotl amotl deleted the collab/fsspec-most-recent branch August 14, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant