Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fsspec for all types of file access #567

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

gutzbenj
Copy link
Member

@gutzbenj gutzbenj commented Jan 27, 2022

After our recent PR at fsspec (patch brought in as monkey patch), we can finally drop dogpile.cache.

Fixes #243 #474 #491

@gutzbenj gutzbenj requested a review from amotl January 27, 2022 22:55
@gutzbenj gutzbenj changed the title Use fsspec for all types of file access using a monkey patch Use fsspec for all types of file access Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #567 (b8c8d73) into main (7bbe744) will decrease coverage by 0.31%.
The diff coverage is 57.89%.

❗ Current head b8c8d73 differs from pull request most recent head 0d20163. Consider uploading reports for the commit 0d20163 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   90.74%   90.43%   -0.32%     
==========================================
  Files          89       90       +1     
  Lines        5707     5740      +33     
  Branches      469      468       -1     
==========================================
+ Hits         5179     5191      +12     
- Misses        411      435      +24     
+ Partials      117      114       -3     
Flag Coverage Δ
unittests 90.43% <57.89%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wetterdienst/provider/dwd/observation/fileindex.py 100.00% <ø> (ø)
wetterdienst/util/cache.py 90.90% <ø> (+5.54%) ⬆️
wetterdienst/util/fsspec_monkeypatch.py 47.19% <47.19%> (ø)
wetterdienst/provider/eccc/observation/api.py 83.97% <50.00%> (+0.43%) ⬆️
wetterdienst/__init__.py 72.72% <100.00%> (+4.30%) ⬆️
wetterdienst/provider/dwd/forecast/api.py 77.40% <100.00%> (+0.10%) ⬆️
wetterdienst/provider/dwd/index.py 100.00% <100.00%> (+4.16%) ⬆️
wetterdienst/provider/dwd/observation/metaindex.py 95.65% <100.00%> (+3.02%) ⬆️
wetterdienst/provider/dwd/radar/index.py 100.00% <100.00%> (ø)
wetterdienst/util/network.py 97.50% <100.00%> (+23.58%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bbe744...0d20163. Read the comment docs.

@gutzbenj gutzbenj force-pushed the monkey-patch-fsspec branch 6 times, most recently from 3573ead to b8c8d73 Compare January 28, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant