-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IN-500 eggd_generate_variant_workbook v2.9.0 #196
IN-500 eggd_generate_variant_workbook v2.9.0 #196
Conversation
Hello @Aisha-D! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-18 11:19:16 UTC |
Checking commits to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 9 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Aisha-D)
Changes are mainly to keep uranus-centric features currently provided from the handler app to be presented in the workbook. The changes include:
Job showing workbook follows current format provided by uranus pipeline -> https://platform.dnanexus.com/panx/projects/Gjk2JvQ4z5v8fJJ72f5Bxy3Z/monitor/job/Gv94G004z5vBb3QPXp61ZxQQ
Testing page: https://cuhbioinformatics.atlassian.net/wiki/spaces/DV/pages/3193929758/eggd+generate+variant+workbook+-+v2.9.0
This change is