Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get name of sample from file name rather than sheet name #201

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Aisha-D
Copy link
Contributor

@Aisha-D Aisha-D commented Oct 24, 2024

This change is Reviewable

@Aisha-D Aisha-D requested a review from jethror1 October 24, 2024 16:18
@pep8speaks
Copy link

Hello @Aisha-D! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 435:80: E501 line too long (94 > 79 characters)

Copy link
Contributor

@jethror1 jethror1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Aisha-D)

@jethror1 jethror1 merged commit d31eba7 into master Oct 24, 2024
4 checks passed
@jethror1 jethror1 deleted the URA-647-eggd-generate-variant-workbook-v-2-9-0 branch October 24, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants