Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#105 Generate different code if users chooses single file option #142

Merged
merged 10 commits into from
Apr 7, 2024
Merged

#105 Generate different code if users chooses single file option #142

merged 10 commits into from
Apr 7, 2024

Conversation

SchawnnDev
Copy link
Member

No description provided.

@SchawnnDev SchawnnDev changed the title #105 Generate different code if users chooses single file option #105 WIP: Generate different code if users chooses single file option Apr 1, 2024
@SchawnnDev SchawnnDev requested a review from RayanMarmar April 1, 2024 13:19
@SchawnnDev
Copy link
Member Author

needs a review from @Zapharaos & @RayanMarmar

RayanMarmar
RayanMarmar reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@RayanMarmar RayanMarmar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for me, you have initialized all the recommended properties for a proper model.
You only have a small modification to do.

internal/controller/model/add.go Outdated Show resolved Hide resolved
internal/controller/model/add.go Outdated Show resolved Hide resolved
internal/controller/model/add.go Outdated Show resolved Hide resolved
internal/controller/model/add.go Outdated Show resolved Hide resolved
@SchawnnDev SchawnnDev changed the title #105 WIP: Generate different code if users chooses single file option #105 Generate different code if users chooses single file option Apr 7, 2024
@SchawnnDev SchawnnDev merged commit 0e14f93 into main Apr 7, 2024
3 checks passed
@SchawnnDev SchawnnDev deleted the 105-client-generate-different-code-if-users-chooses-single-file-option-v2 branch April 7, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayanMarmar RayanMarmar RayanMarmar left review comments

Assignees
No one assigned
Labels
draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SchawnnDev @RayanMarmar