Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making comments consistent #117

Merged
merged 13 commits into from
May 12, 2024
Merged

Conversation

OmarElChamaa
Copy link
Contributor

No description provided.

SchawnnDev and others added 2 commits April 20, 2024 11:34
* Fix problem generate prompt type

* #80 sdk return options even when launching downloader with only configuration (#89)

* refactor download to always send a complete response

* fixed download unit tests

* fix lint

* fix  download unit tests

* fixed unit tests

* moved tokenizer build path

* #95 Add access token to get class methods in downloader (#96)

* #80 sdk return options even when launching downloader with only configuration (#92)

* Fix problem generate prompt type

* #80 sdk return options even when launching downloader with only configuration (#89)

* refactor download to always send a complete response

* fixed download unit tests

* fix lint

* fix  download unit tests

* fixed unit tests

* moved tokenizer build path

---------

Co-authored-by: qgerling <[email protected]>

* hotfix downloader options : unexpected object rewriting (#93)

* hotfix downloader options : writing object but expected read-only

* hotfix downloader options : unit test - writing object but expected read-only

* added access token to set class methods

* fixed unit tests

* fixed unit tests

* reformat code

---------

Co-authored-by: Paul <[email protected]>
Co-authored-by: qgerling <[email protected]>
Co-authored-by: Matthieu FREITAG <[email protected]>

* #97 sdk contributing (#99)

* documentation : code of conduct

* documentation : contributing

* #100 sdk readme (#102)

* MIT License (#104)

* Added unit tests (#103)

* Update README.md

* Modification of the conversation model workflow (#105)

* Modification of the conversation model workflow

* fix linter

* Modification of the transformers create_pieline workflow (#106)

* Modification of the transformers create_pieline workflow

* fix linter

* Manage models on CPU and GPU (#107)

* Manage models on CPU and GPU

* Fix linter

* 91 sdk update model management for multiple device (#108)

* Manage models on CPU and GPU

* Fix linter

* fix demos

* Making model module optional for when only downloading tokenizers (#109)

* Making model module optional for when only downloading tokenizers

* Fixed condition

* Fixed condition and added test for download method

* Optimised condition and added test for process method

* Lint fix

* Fixed new tests

* Fixed major bug and updated tests

* Fixed conditions

* Fixed failing test

* Added model management demos (#112)

* Added model management demos

* Flake8 Fix

* Fixed Major bug (#113)

* #57 Added single file option (#114)

* added single file option

* fixed missing

* PR develop into main: fix lint

---------

Co-authored-by: qgerling <[email protected]>
Co-authored-by: RayanMarmar <[email protected]>
Co-authored-by: Matthieu FREITAG <[email protected]>
Co-authored-by: Omar El Chamaa <[email protected]>
Co-authored-by: Quentin <[email protected]>
@OmarElChamaa OmarElChamaa requested a review from SchawnnDev April 28, 2024 19:45
@OmarElChamaa OmarElChamaa added enhancement New feature or request sdk labels Apr 28, 2024
@OmarElChamaa OmarElChamaa self-assigned this Apr 28, 2024
Copy link
Member

@SchawnnDev SchawnnDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF are you DOING????

@OmarElChamaa OmarElChamaa requested a review from SchawnnDev May 6, 2024 17:45
sdk/downloader.py Outdated Show resolved Hide resolved
sdk/downloader.py Outdated Show resolved Hide resolved
sdk/models/model.py Outdated Show resolved Hide resolved
sdk/models/model.py Outdated Show resolved Hide resolved
@OmarElChamaa OmarElChamaa requested a review from SchawnnDev May 7, 2024 10:17
@OmarElChamaa OmarElChamaa merged commit a0acc89 into develop May 12, 2024
2 checks passed
SchawnnDev added a commit that referenced this pull request May 13, 2024
@SchawnnDev SchawnnDev deleted the 115-sdk-make-comments-consistent branch May 16, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants