Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use top-level parameters for use_pip & co instead of exts_default_options for PythonBundle easyconfigs #21292

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Flamefire
Copy link
Contributor

It is easier in the top-level and might cause confusion with easybuilders/easybuild-easyblocks#3428

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 18 out of 18 (18 easyconfigs in total)
n1552 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/b267a7aab05028cfa5974b7b356c0e6b for a full test report.

@boegel boegel changed the title Move exts_default_options to top-level parameters forPythonBundle ECs use top-level parameters for use_pip & co instead of exts_default_options for PythonBundle easyconfigs Sep 11, 2024
@boegel boegel added this to the 4.x milestone Sep 11, 2024
@boegel
Copy link
Member

boegel commented Sep 11, 2024

@boegelbot please test @ generoso

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21292 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21292 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14241

Test results coming soon (I hope)...

- notification for comment with ID 2342901217 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 18 out of 18 (18 easyconfigs in total)
cns4 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2486e59e8b59efd73727de1ef894e748 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 11, 2024

Going in, thanks @Flamefire!

@boegel boegel merged commit eb81403 into easybuilders:develop Sep 11, 2024
9 checks passed
@boegel boegel modified the milestones: 4.x, 4.9.3 Sep 11, 2024
@Flamefire Flamefire deleted the default-opts branch September 11, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants