-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add effect size (Cohen's d) to estimate_contrasts
#227
base: main
Are you sure you want to change the base?
Changes from 6 commits
31f1596
d439676
eadb798
7d0c5bc
219935d
719f546
0c22e29
a3aad0d
7ebdc3c
2fbce7a
d1e0fad
e96d5eb
683f2fb
5f8f625
0f6ee12
9dbcbc6
0140e20
7078a7e
f2d742e
4ff060f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Type: Package | ||
Package: modelbased | ||
Title: Estimation of Model-Based Predictions, Contrasts and Means | ||
Version: 0.8.6.3 | ||
Version: 0.8.6.4 | ||
Authors@R: | ||
c(person(given = "Dominique", | ||
family = "Makowski", | ||
|
@@ -22,7 +22,12 @@ Authors@R: | |
family = "Patil", | ||
role = "aut", | ||
email = "[email protected]", | ||
comment = c(ORCID = "0000-0003-1995-6531", Twitter = "@patilindrajeets"))) | ||
comment = c(ORCID = "0000-0003-1995-6531", Twitter = "@patilindrajeets")), | ||
person(given = "Rémi", | ||
family = "Thériault", | ||
role = c("aut"), | ||
email = "[email protected]", | ||
comment = c(ORCID = "0000-0003-4315-6788", Twitter = "@rempsyc"))) | ||
Maintainer: Dominique Makowski <[email protected]> | ||
Description: Implements a general interface for model-based estimations | ||
for a wide variety of models (see list of supported models using the | ||
|
@@ -63,12 +68,13 @@ Suggests: | |
rstanarm, | ||
rtdists, | ||
see (>= 0.7.4), | ||
bootES, | ||
testthat | ||
VignetteBuilder: | ||
knitr | ||
Encoding: UTF-8 | ||
Language: en-US | ||
RoxygenNote: 7.2.3.9000 | ||
RoxygenNote: 7.2.3 | ||
Config/testthat/edition: 3 | ||
Config/testthat/parallel: true | ||
Roxygen: list(markdown = TRUE) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,9 +11,49 @@ | |
#' "bonferroni", "BH", "BY", "fdr" or "none". See the p-value adjustment | ||
#' section in the `emmeans::test` documentation. | ||
#' @param adjust Deprecated in favour of `p_adjust`. | ||
#' @param effectsize Desired measure of standardized effect size, one of "none" | ||
#' (default), "emmeans", "marginal", or "bootES". | ||
#' @param bootES_type Specifies the type of effect-size measure to | ||
#' estimate when using `effectsize = "bootES"`. One of `c("unstandardized", | ||
#' "cohens.d", "hedges.g", "cohens.d.sigma", "r", "akp.robust.d")`. See` | ||
#' effect.type` argument of [bootES::bootES] for details. | ||
#' @param bootstraps The number of bootstrap resamples to perform. | ||
#' | ||
#' @inherit estimate_slopes details | ||
#' | ||
#' @section Effect Size: By default, `estimate_contrasts` reports no | ||
#' standardized effect size on purpose. Should one request one, some things | ||
#' are to keep in mind. As the authors of `emmeans` write, "There is | ||
#' substantial disagreement among practitioners on what is the appropriate | ||
#' sigma to use in computing effect sizes; or, indeed, whether any effect-size | ||
#' measure is appropriate for some situations. The user is completely | ||
#' responsible for specifying appropriate parameters (or for failing to do | ||
#' so)." | ||
#' | ||
#' In particular, effect size method `"bootES"` does not correct | ||
#' for covariates in the model, so should probably only be used when there is | ||
rempsyc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
#' just one categorical predictor (with however many levels). Some believe that | ||
#' if there are multiple predictors or any covariates, it is important to | ||
#' re-compute sigma adding back in the response variance associated with the | ||
#' variables that aren't part of the contrast. | ||
#' | ||
#' `effectsize = "emmeans"` uses [emmeans::eff_size] with | ||
rempsyc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
#' `sigma = stats::sigma(model)`, `edf = stats::df.residual(model)` and | ||
#' `method = "identity")`. This standardizes using the MSE (sigma). Some believe | ||
#' this works when the contrasts are the only predictors in the model, but not | ||
#' when there are covariates. The response variance accounted for by the | ||
#' covariates should not be removed from the SD used to standardize. Otherwise, | ||
#' _d_ will be overestimated. | ||
#' | ||
#' `effectsize = "marginal"` uses the following formula to compute effect | ||
#' size: `d_adj <- t * se_b / sigma * sqrt(1 - R2_cov)`. This standardized | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also means that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, one thing to note, is that previously I hardcoded sigma as as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly, in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, in that case you're just making a wrapper around There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. But I don't know what we should do (wrapper around There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nothing 😜🤷♂️ |
||
#' using the response SD with only the between-groups variance on the focal | ||
#' factor/contrast removed. This allows for groups to be equated on their | ||
#' covariates, but creates an appropriate scale for standardizing the response. | ||
#' | ||
#' `effectsize = "bootES"` uses bootstrapping (defaults to a low value of | ||
#' 200) through [bootES::bootES]. Adjust for contrasts, but not for covariates. | ||
#' | ||
#' @examplesIf require("emmeans", quietly = TRUE) | ||
#' # Basic usage | ||
#' model <- lm(Sepal.Width ~ Species, data = iris) | ||
|
@@ -83,6 +123,9 @@ estimate_contrasts <- function(model, | |
p_adjust = "holm", | ||
method = "pairwise", | ||
adjust = NULL, | ||
effectsize = "none", | ||
bootstraps = 200, | ||
bootES_type = "cohens.d", | ||
...) { | ||
# Deprecation | ||
if (!is.null(adjust)) { | ||
|
@@ -135,6 +178,61 @@ estimate_contrasts <- function(model, | |
contrasts$contrast <- NULL | ||
contrasts <- cbind(level_cols, contrasts) | ||
|
||
# Add standardized effect size | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we split that into its own separate internal function .estimate_contrasts_effecsize()? So that it's more encapsulated |
||
if (!effectsize %in% c("none", "emmeans", "marginal", "bootES")) { | ||
message("Unsupported effect size '", effectsize, "', returning none.") | ||
} | ||
|
||
if (effectsize == "emmeans") { | ||
eff <- emmeans::eff_size( | ||
estimated, sigma = stats::sigma(model), | ||
edf = stats::df.residual(model), method = "identity") | ||
eff <- as.data.frame(eff) | ||
eff <- eff[c(2, 5:6)] | ||
names(eff) <- c("effect_size", "es_CI_low", "es_CI_high") | ||
contrasts <- cbind(contrasts, eff) | ||
|
||
} else if (effectsize == "marginal") { | ||
# d_adj <- t * se_b / sigma * sqrt(1 - R2_cov) | ||
R2_cov <- summary(model)$r.squared | ||
d_adj <- contrasts$t * contrasts$SE / sigma(model) * sqrt(1 - R2_cov) | ||
contrasts <- cbind(contrasts, marginal_d = d_adj) | ||
|
||
} else if (effectsize == "bootES") { | ||
if (bootstraps < 500) { | ||
message("Number of bootstraps probably too low. Consider increasing it.") | ||
} | ||
|
||
insight::check_if_installed("bootES") | ||
dat <- insight::get_data(model) | ||
resp <- insight::find_response(model) | ||
group <- names([email protected]$xlev) | ||
contrast <- estimated@misc$con.coef | ||
|
||
contrast <- lapply(seq_len(nrow(contrast)), function(x) { | ||
z <- contrast[x, ] | ||
names(z) <- levels(as.factor(dat[[group]])) | ||
z | ||
}) | ||
|
||
es.lists <- lapply(contrast, function(x) { | ||
y <- bootES::bootES( | ||
data = stats::na.omit(dat), | ||
R = bootstraps, | ||
data.col = resp, | ||
group.col = group, | ||
contrast = x, | ||
effect.type = bootES_type | ||
) | ||
y <- as.data.frame(summary(y))}) | ||
|
||
eff <- do.call(rbind, es.lists) | ||
eff <- eff[1:3] | ||
names(eff) <- c(bootES_type, paste0(bootES_type, "_CI_low"), | ||
paste0(bootES_type, "es_CI_high")) | ||
|
||
contrasts <- cbind(contrasts, eff) | ||
} | ||
|
||
# Table formatting | ||
attr(contrasts, "table_title") <- c("Marginal Contrasts Analysis", "blue") | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not document these in the main interface (to not alourdir the list of arguments) and allow their change via Kwargs, and mention them within the details section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want this merged before submitting the paper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible why not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit crunched right now with faculty job applications, talks, and other deadlines but I will try