Prepare CRAN release #369
Merged
Prepare CRAN release #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Ok, the final fine-tuning is done, I think you can submit... |
This comment was marked as outdated.
This comment was marked as outdated.
|
will submit today :) |
Great! There's a minimal time pressure for me, as packages ggeffects (and as a consequence, also insight) are broken due to the marginaleffects update, and I need to submit updates to CRAN, too. And ggeffects now relies on modelbased for contrasts, because I don't want to do all the work we did here for modelbased twice when there are substantial changes in marginaleffects 😬 |
|
it has been submitted 40min ago, fingers crossed it passes the checks 😄 |
|
Thanks, on its way to CRAN. Team, this breaks 'report'. |
|
@rempsyc 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
byargument #373marginalizeand its options #374bymatters? vincentarelbundock/marginaleffects#1373 gets fixed for CRAN submission 😎 (and add tests when fixed)