Export zoo method for model_parameters generic
#804
Conversation
There was a problem hiding this comment.
@jimrothstein Thanks!
This looks good, overall. Can you rebase with the main branch and see why there are changes to .Rd files? That is not expected.
Feel free to make these changes here, or open a new PR.
|
Got the latest version (git pull upstream main) and then added TWO LINES: model_parameters.zoo <- model_parameters.default` Look any better? |
|
Yes, but there is still the issue of changes to the |
|
On my local machine, I get 28 warnings when I document(). Need to install all the easystats packages, I think. And Sorry, not as easy as I first thought. |
|
Sorry for the troubles. Try running: install.packages("easystats")
easystats::install_latest()Refresh your R session and then try again to re-document. |
|
Doing it now ... 16 warnings .... looks like need to manually install more packages. more dependencies ... could take some time. I am US west coast time (Oregon) and getting late. Will finish later. also needs some Ubuntu packages ... I'll get there. |
|
Have all packages .... document() .... no warnings. Also ?model_parameters.zoo has no help. Not sure about *.Rd files More tomorrow. |
IndrajeetPatil
changed the title
zoo method for model_parameters generic
|
Looks good now. I will merge this once the builds pass. |
There was a problem hiding this comment.
Thanks, @jimrothstein! :)
Feel free to work more extensively on #746 in a new PR. You know the deal now. ;)
|
Will do ! Later today. |
Part of #746