Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix python search for gobject integration #266

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DjLegolas
Copy link

Fixes #265.

Proposed changes:

  • remove the python3 search from src/meson.build.
  • add additional build with Gobject integration.

@DjLegolas DjLegolas changed the title fix incorrect use of python package build: fix python search for gobject integration Apr 19, 2024
@ebassi
Copy link
Owner

ebassi commented Aug 12, 2024

Would it be possible to split it into two separate commits:

  1. the change for the Python installation
  2. the GitHub workflow update

and rebase it on the main development branch? I've changed the minimum required version of Meson to 1.0.

Also, I'm not sure why the build hasn't started any check; I don't have a Windows machine, so I rely on the CI pipeline to check if it's actually working.

@DjLegolas DjLegolas force-pushed the fix-python-issue branch 4 times, most recently from 8b2563e to 84ad61a Compare August 17, 2024 20:11
@ebassi
Copy link
Owner

ebassi commented Aug 19, 2024

From the build log: FileNotFoundError: [WinError 2] The system cannot find the file specified

@DjLegolas DjLegolas marked this pull request as draft January 5, 2025 22:38
@DjLegolas DjLegolas marked this pull request as ready for review January 5, 2025 22:38
@DjLegolas DjLegolas force-pushed the fix-python-issue branch 2 times, most recently from 83fec69 to 595682e Compare January 6, 2025 21:13
@DjLegolas
Copy link
Author

Well, still need to understand why it's failing (it fails to find something...)
In addition, I'll enable the introspection tests. But currently it fails on my machine so still investigating it.

@DjLegolas DjLegolas force-pushed the fix-python-issue branch 10 times, most recently from a65ac8f to 2876d7c Compare January 24, 2025 21:23
When compiling with Gobject integration on Windows, the build fails because it finds the incorrect
python interpreter.

Closes: ebassi#265
@DjLegolas DjLegolas force-pushed the fix-python-issue branch 2 times, most recently from 153de4f to df00f38 Compare January 24, 2025 22:21
@DjLegolas DjLegolas force-pushed the fix-python-issue branch 5 times, most recently from 5599cb5 to d3711eb Compare January 25, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build fails when adding introspection integration
2 participants