More updates to the message checker #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents searches from returning messages that include "tech support" rather than the magic keyword "tech-support" (with the hyphen).
Slack only allows us to search from a date, not a datetime (times can be used too, but they apply to times on every day). Sometimes, it seems slack's search just doesn't return messages for a while. We now make it check for the whole of yesterday AND today. We also don't need to give it a "before" search term.
alarthast
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like slack's search sometimes takes a while to pick up certain messages.
E.g. this message from Rich didn't get SOS'd when he posted it. When I tried searching slack (in the UI, not with the API) a few minutes after the message was posted, it wasn't returning it in the search results when I searched using the BennettBot message checker query. It only came up if I also explicitly put
from:@<rich>into the query.However, this morning the search UI (and the API) are returning that message. So, I think some messages slip through the cracks somehow, don't get sent to our slack bolt app, and also don't get returned in search results. But they do get picked up some time later. Rich's message was sent at 9:30pm, and the message checker was only checking messages from the same day, so it only had a couple of hours to get through. This PR makes it check for all of yesterday AND today, to give it more of a chance to find them.
Also drive-by fixes: