Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep job-runner tests in ignored list #612

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Keep job-runner tests in ignored list #612

merged 1 commit into from
Oct 10, 2024

Conversation

alarthast
Copy link
Contributor

  • No change to code: removal of a TODO comment that arose from my misunderstanding of this conversation
  • The workflow to publish the docker image is its separate GHA, so the Tests GHA still does not run on main and Bennett Bot should still skip trying to find it

rebkwok
rebkwok approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@rebkwok rebkwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I also mis-read that conversation in exactly the same way

@alarthast alarthast merged commit 77be7d8 into main Oct 10, 2024
6 checks passed
@alarthast alarthast deleted the ignore-job-runner-tests branch October 10, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebkwok rebkwok rebkwok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alarthast @rebkwok