chore(drone): automate deployments - EUBFR-146 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhuard
reviewed
Apr 19, 2019
| eubfr_content_repository, | ||
| ] | ||
| commands: | ||
| - npx serverless config credentials --provider aws --key $${AWS_ACCESS_KEY_ID} --secret $${AWS_SECRET_ACCESS_KEY} |
There was a problem hiding this comment.
isn't there a risk of exposing the secrets during the drone deployment here? 🤔
There was a problem hiding this comment.
You're right, they are, unfortunately.
I'll probably have to find another way to manage secrets in our scripts (having them as env variables only and not configuring them for .aws system-wide didn't work, adding WIP flag.
Co-Authored-By: kalinchernev <[email protected]>
Co-Authored-By: kalinchernev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
WIP: refactor scripts to rely only on environment variables for AWS credentials. Or find a way for a drone command to use secrets from environment variables without exposing them.
Please refer to https://github.com/ec-europa/eubfr-data-lake/blob/cbf3dc2255f0b731a76d73369ecb6c9cf310ef61/docs/AUTOMATION.md for detailed instructions on how to test.