Issue #23: Renamed targed.

ec-europa · Oct 5, 2017 · 30b234c · 30b234c
1 parent a57b709
commit 30b234c
Show file tree

Hide file tree

Showing 36 changed files with 240 additions and 207 deletions.
diff --git a/spec/Messages/Requests/CreateRequestSpec.php b/spec/Messages/Requests/CreateRequestSpec.php
@@ -8,7 +8,7 @@
 use EC\Poetry\Messages\Components\ReferenceDocument;
 use EC\Poetry\Messages\Components\ReturnAddress;
 use EC\Poetry\Messages\Components\Source;
-use EC\Poetry\Messages\Components\Target;
+use EC\Poetry\Messages\Components\Attribution;
 use EC\Poetry\Messages\Requests\CreateRequest;
 use EC\Poetry\Services\Settings;
 use PhpSpec\ObjectBehavior;
@@ -17,7 +17,7 @@
 use spec\EC\Poetry\Messages\Traits\AssertReferenceDocumentsTrait;
 use spec\EC\Poetry\Messages\Traits\AssertReturnAddressTrait;
 use spec\EC\Poetry\Messages\Traits\AssertSourceTrait;
-use spec\EC\Poetry\Messages\Traits\AssertTargetsTrait;
+use spec\EC\Poetry\Messages\Traits\AssertAttributionsTrait;
 
 class CreateRequestSpec extends ObjectBehavior
 {
@@ -26,7 +26,7 @@ class CreateRequestSpec extends ObjectBehavior
     use AssertReturnAddressTrait;
     use AssertContactsTrait;
     use AssertReferenceDocumentsTrait;
-    use AssertTargetsTrait;
+    use AssertAttributionsTrait;
 
     function let(Identifier $identifier, Settings $settings)
     {
@@ -63,8 +63,8 @@ function it_has_reference_documents(ReferenceDocument $document1, ReferenceDocum
         $this->assertReferenceDocuments($document1, $document2, $document3, $document4);
     }
 
-    function it_has_targets(Target $target1, Target $target2, Target $target3, Target $target4)
+    function it_has_attributions(Attribution $attribution1, Attribution $attribution2, Attribution $attribution3, Attribution $attribution4)
     {
-        $this->assertTargets($target1, $target2, $target3, $target4);
+        $this->assertAttributions($attribution1, $attribution2, $attribution3, $attribution4);
     }
 }
diff --git a/spec/Messages/Traits/AssertAttributionsTrait.php b/spec/Messages/Traits/AssertAttributionsTrait.php
@@ -0,0 +1,46 @@
+<?php
+
+namespace spec\EC\Poetry\Messages\Traits;
+
+use EC\Poetry\Messages\Components\Attribution;
+
+/**
+ * Trait AssertAttributionsTrait
+ *
+ * @method addAttribution(Attribution $attribution)
+ * @method setAttribution(array $documents)
+ * @method getAttributions()
+ * @method withAttribution()
+ *
+ * @package spec\EC\Poetry\Messages\Traits
+ */
+trait AssertAttributionsTrait
+{
+    /**
+     * Assert Component.
+     *
+     * @param \EC\Poetry\Messages\Components\Attribution $attribution1
+     * @param \EC\Poetry\Messages\Components\Attribution $attribution2
+     * @param \EC\Poetry\Messages\Components\Attribution $attribution3
+     * @param \EC\Poetry\Messages\Components\Attribution $attribution4
+     */
+    function assertAttributions($attribution1, $attribution2, $attribution3, $attribution4)
+    {
+        $this->addAttribution($attribution1)->shouldReturn($this);
+        $this->addAttribution($attribution2)->shouldReturn($this);
+        $this->getAttributions()->shouldBeArray();
+        $this->getAttributions()[0]->shouldBe($attribution1);
+        $this->getAttributions()[1]->shouldBe($attribution2);
+
+        $this->setAttribution([$attribution3, $attribution4])->shouldReturn($this);
+        $this->getAttributions()[0]->shouldNotBe($attribution1);
+        $this->getAttributions()[1]->shouldNotBe($attribution2);
+        $this->getAttributions()[0]->shouldBe($attribution3);
+        $this->getAttributions()[1]->shouldBe($attribution4);
+
+        $this->withAttribution()->shouldBeAnInstanceOf(Attribution::class);
+        $this->withAttribution()->shouldBeAnInstanceOf(Attribution::class);
+        $this->getAttributions()[2]->shouldBeAnInstanceOf(Attribution::class);
+        $this->getAttributions()[3]->shouldBeAnInstanceOf(Attribution::class);
+    }
+}
diff --git a/spec/Messages/Traits/AssertStatusesTrait.php b/spec/Messages/Traits/AssertStatusesTrait.php
@@ -5,7 +5,7 @@
 use EC\Poetry\Messages\Components as Component;
 
 /**
- * Trait AssertTargetsTrait
+ * Trait AssertAttributionsTrait
  *
  * @method addStatus(Component\Status $status)
  * @method setStatuses(array $statuses)

diff --git a/spec/Messages/Traits/AssertTargetsTrait.php b/spec/Messages/Traits/AssertTargetsTrait.php
diff --git a/src/Messages/Components/Target.php → src/Messages/Components/Attribution.php b/src/Messages/Components/Target.php → src/Messages/Components/Attribution.php
@@ -9,11 +9,11 @@
 use Symfony\Component\Validator\Constraints as Assert;
 
 /**
- * Class Target
+ * Class Attribution
  *
  * @package EC\Poetry\Messages\Components
  */
-class Target extends AbstractComponent
+class Attribution extends AbstractComponent
 {
     use WithContactsTrait;
 
@@ -34,7 +34,7 @@ class Target extends AbstractComponent
      */
     public function getTemplate()
     {
-        return 'components::target';
+        return 'components::attribution';
     }
 
     /**
@@ -85,7 +85,8 @@ public function getFormat()
 
     /**
      * @param mixed $format
-     * @return Target
+     *
+     * @return Attribution
      */
     public function setFormat($format)
     {
@@ -105,7 +106,8 @@ public function getLanguage()
 
     /**
      * @param mixed $language
-     * @return Target
+     *
+     * @return Attribution
      */
     public function setLanguage($language)
     {
@@ -124,7 +126,8 @@ public function getTrackChanges()
 
     /**
      * @param mixed $trackChanges
-     * @return Target
+     *
+     * @return Attribution
      */
     public function setTrackChanges($trackChanges)
     {
@@ -143,7 +146,8 @@ public function getAction()
 
     /**
      * @param mixed $action
-     * @return Target
+     *
+     * @return Attribution
      */
     public function setAction($action)
     {
@@ -162,7 +166,8 @@ public function getRemark()
 
     /**
      * @param mixed $remark
-     * @return Target
+     *
+     * @return Attribution
      */
     public function setRemark($remark)
     {
@@ -181,7 +186,8 @@ public function getDelay()
 
     /**
      * @param mixed $delay
-     * @return Target
+     *
+     * @return Attribution
      */
     public function setDelay($delay)
     {
@@ -200,7 +206,8 @@ public function getDelayFormat()
 
     /**
      * @param mixed $delayFormat
-     * @return Target
+     *
+     * @return Attribution
      */
     public function setDelayFormat($delayFormat)
     {
@@ -219,7 +226,8 @@ public function getAcceptedDelay()
 
     /**
      * @param mixed $acceptedDelay
-     * @return Target
+     *
+     * @return Attribution
      */
     public function setAcceptedDelay($acceptedDelay)
     {
@@ -238,7 +246,8 @@ public function getAcceptedDelayFormat()
 
     /**
      * @param mixed $acceptedDelayFormat
-     * @return Target
+     *
+     * @return Attribution
      */
     public function setAcceptedDelayFormat($acceptedDelayFormat)
     {
@@ -255,9 +264,9 @@ public function getTranslatedFile()
         return $this->translatedFile;
     }
 
-    /**
+  /**
      * @param mixed $translatedFile
-     * @return Target
+     * @return Attribution
      */
     public function setTranslatedFile($translatedFile)
     {
@@ -267,23 +276,23 @@ public function setTranslatedFile($translatedFile)
     }
 
     /**
-     * @return \EC\Poetry\Messages\Components\TargetReturnAddress[]
+     * @return \EC\Poetry\Messages\Components\AttributionReturnAddress[]
      */
     public function getReturnAddresses()
     {
         return $this->returnAddresses;
     }
 
     /**
-     * @param \EC\Poetry\Messages\Components\TargetReturnAddress[] $returnAddresses
+     * @param \EC\Poetry\Messages\Components\AttributionReturnAddress[] $returnAddresses
      */
     public function setReturnAddresses($returnAddresses)
     {
         $this->returnAddresses = $returnAddresses;
     }
 
     /**
-     * @param \EC\Poetry\Messages\Components\TargetReturnAddress $returnAddress
+     * @param \EC\Poetry\Messages\Components\AttributionReturnAddress $returnAddress
      */
     public function addReturnAddress($returnAddress)
     {
@@ -293,12 +302,12 @@ public function addReturnAddress($returnAddress)
     /**
      * Factory method: create a new contact and return its instance.
      *
-     * @return \EC\Poetry\Messages\Components\TargetReturnAddress
+     * @return \EC\Poetry\Messages\Components\AttributionReturnAddress
      *      Contact instance.
      */
     public function withReturnAddress()
     {
-        $this->returnAddresses[] = new TargetReturnAddress();
+        $this->returnAddresses[] = new AttributionReturnAddress();
 
         return end($this->returnAddresses);
     }

diff --git a/...ssages/Components/TargetReturnAddress.php → ...s/Components/AttributionReturnAddress.php b/...ssages/Components/TargetReturnAddress.php → ...s/Components/AttributionReturnAddress.php
@@ -3,18 +3,18 @@
 namespace EC\Poetry\Messages\Components;
 
 /**
- * Class TargetReturnAddress
+ * Class AttributionReturnAddress
  *
  * @package EC\Poetry\Messages\Components
  */
-class TargetReturnAddress extends ReturnAddress
+class AttributionReturnAddress extends ReturnAddress
 {
 
     /**
      * {@inheritdoc}
      */
     public function getTemplate()
     {
-        return 'components::target-return-address';
+        return 'components::attribution-return-address';
     }
 }
diff --git a/src/Messages/Components/Constraints/DetailsDestination.php b/src/Messages/Components/Constraints/DetailsDestination.php
@@ -7,7 +7,7 @@
 
 /**
  * @Annotation
- * @Target({"PROPERTY", "METHOD", "ANNOTATION"})
+ * @Attribution({"PROPERTY", "METHOD", "ANNOTATION"})
  *
  * @package EC\Poetry\Messages\Components\Constraints
  */

diff --git a/src/Messages/Components/Constraints/DetailsProcedure.php b/src/Messages/Components/Constraints/DetailsProcedure.php
@@ -7,7 +7,7 @@
 
 /**
  * @Annotation
- * @Target({"PROPERTY", "METHOD", "ANNOTATION"})
+ * @Attribution({"PROPERTY", "METHOD", "ANNOTATION"})
  *
  * @package EC\Poetry\Messages\Components\Constraints
  */

diff --git a/src/Messages/Components/Constraints/DetailsType.php b/src/Messages/Components/Constraints/DetailsType.php
@@ -7,7 +7,7 @@
 
 /**
  * @Annotation
- * @Target({"PROPERTY", "METHOD", "ANNOTATION"})
+ * @Attribution({"PROPERTY", "METHOD", "ANNOTATION"})
  *
  * @package EC\Poetry\Messages\Components\Constraints
  */

diff --git a/src/Messages/Components/Constraints/DocumentFormat.php b/src/Messages/Components/Constraints/DocumentFormat.php
@@ -7,7 +7,7 @@
 
 /**
  * @Annotation
- * @Target({"PROPERTY", "METHOD", "ANNOTATION"})
+ * @Attribution({"PROPERTY", "METHOD", "ANNOTATION"})
  *
  * @package EC\Poetry\Messages\Components\Constraints
  */

diff --git a/src/Messages/Components/Constraints/SourceChannel.php b/src/Messages/Components/Constraints/SourceChannel.php
@@ -7,7 +7,7 @@
 
 /**
  * @Annotation
- * @Target({"PROPERTY", "METHOD", "ANNOTATION"})
+ * @Attribution({"PROPERTY", "METHOD", "ANNOTATION"})
  *
  * @package EC\Poetry\Messages\Components\Constraints
  */

diff --git a/src/Messages/Components/Constraints/SourceDeadlineStatus.php b/src/Messages/Components/Constraints/SourceDeadlineStatus.php
@@ -7,7 +7,7 @@
 
 /**
  * @Annotation
- * @Target({"PROPERTY", "METHOD", "ANNOTATION"})
+ * @Attribution({"PROPERTY", "METHOD", "ANNOTATION"})
  *
  * @package EC\Poetry\Messages\Components\Constraints
  */

diff --git a/src/Messages/Components/Constraints/StatusCode.php b/src/Messages/Components/Constraints/StatusCode.php
@@ -7,7 +7,7 @@
 
 /**
  * @Annotation
- * @Target({"PROPERTY", "METHOD", "ANNOTATION"})
+ * @Attribution({"PROPERTY", "METHOD", "ANNOTATION"})
  *
  * @package EC\Poetry\Messages\Components\Constraints
  */