Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEPT-1534: Consider if not to rename targets into attribution #23

Open
ademarco opened this issue Sep 22, 2017 · 2 comments
Open

NEPT-1534: Consider if not to rename targets into attribution #23

ademarco opened this issue Sep 22, 2017 · 2 comments
Assignees
@imanoleguskiza
Labels
1.0.0

Comments

@ademarco
Copy link
Collaborator

We can now set attributions via the Target component, we should maybe consider to rename it into Attribution.
@ademarco ademarco changed the title NEPT-1458: Consider if not to rename targets into attribution NEPT-1534: Consider if not to rename targets into attribution Sep 22, 2017
@imanoleguskiza
Copy link
Contributor

I think I would go further and rename all the components so that they reflect better the naming they use in DGT. What do you think?

@imanoleguskiza imanoleguskiza self-assigned this Oct 4, 2017
@ademarco
Copy link
Collaborator Author

ademarco commented Oct 4, 2017

I'm ok with finding better names but I would keep them in English, then I'd add a mapping table as documentation if necessary.

imanoleguskiza added a commit that referenced this issue Oct 5, 2017
@imanoleguskiza
Issue #23: Renamed targed.
30b234c
imanoleguskiza added a commit that referenced this issue Oct 5, 2017
@imanoleguskiza
Issue #23: Merge remote-tracking branch 'origin/master' into 23-renam…
ba73a7d 
…e-components.
@ademarco ademarco added the 1.0.0 label Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imanoleguskiza imanoleguskiza

Labels
1.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ademarco @imanoleguskiza