Merge pull request #110 from ec-europa/feature/DQA-3678-3x

DQA-3678: [3.x] Sniff to check form_alter() usage.

phpcs/Standards/QualityAssurance/Sniffs/Functions/DrupalForbiddenHooksSniff.php

@@ -0,0 +1,93 @@
+<?php
+/**
+ * QualityAssurance_Sniffs_Functions_DrupalForbiddenHooksSniff.
+ *
+ * PHP version 5
+ *
+ * @category PHP
+ * @package  PHP_CodeSniffer
+ * @link     http://pear.php.net/package/PHP_CodeSniffer
+ */
+
+/**
+ * Check for usage of forbidden hooks.
+ *
+ * @category PHP
+ * @package  PHP_CodeSniffer
+ * @link     http://pear.php.net/package/PHP_CodeSniffer
+ */
+class QualityAssurance_Sniffs_Functions_DrupalForbiddenHooksSniff implements PHP_CodeSniffer_Sniff
+{
+
+    /**
+     * A list of forbidden hooks with their alternatives.
+     *
+     * The value is empty string if no alternative exists, i.e. the hook should
+     * just not be used.
+     *
+     * @var array
+     */
+    public $forbiddenHooks = ['hook_form_alter' => 'hook_form_FORM_ID_alter() or hook_form_BASE_FORM_ID_alter()'];
+
+    /**
+     * A list of file extensions to check.
+     *
+     * @var array
+     */
+    public $extensions = [
+        'inc',
+        'module',
+    ];
+
+    /**
+     * Returns an array of tokens this test wants to listen for.
+     *
+     * @return array
+     */
+    public function register()
+    {
+        return [T_FUNCTION];
+    }//end register()
+
+
+    /**
+     * Processes this test, when one of its tokens is encountered.
+     *
+     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param int                  $stackPtr  The position of the current token
+     *                                        in the stack passed in $tokens.
+     *
+     * @return void
+     */
+    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+    {
+        $filename  = basename($phpcsFile->getFilename());
+        $exploded  = explode('.', $filename);
+        $extension = end($exploded);
+        if (false === in_array($extension, $this->extensions) && $filename !== 'template.php') {
+            return;
+        }
+
+        $module   = $exploded[0];
+        $tokens   = $phpcsFile->getTokens();
+        $function = $tokens[($stackPtr + 2)]['content'];
+        if ($extension === 'php' && $filename === 'template.php') {
+            $directories = explode('/', $phpcsFile->getFilename());
+            $module = $directories[count($directories) - 2];
+        }
+        foreach ($this->forbiddenHooks as $hook => $replacement) {
+            if (true === ($function === str_replace('hook', $module, $hook))) {
+                $warning = 'The usage of the hook %s() is forbidden';
+                $data = [$hook];
+                if (false === empty($replacement)) {
+                    $warning .= ', instead use %s.';
+                    $data[] = $replacement;
+                } else {
+                    $warning .= '.';
+                }
+
+                $phpcsFile->addError($warning, $stackPtr, 'ForbiddenHook', $data);
+            }
+        }
+    }//end process()
+}//end class