Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

Add a temporary fix for the storage config. #7

Open
wants to merge 2 commits into
base: 8.x-1.x
Choose a base branch
from

Conversation

idimopoulos
Copy link
Contributor

@idimopoulos idimopoulos commented Sep 18, 2017

This PR might not be an good solution as the fields can still be created through yaml files.
#8 has a more proper solution for this case but takes a bit more time.

@idimopoulos idimopoulos force-pushed the storage_validation_error branch from 4344813 to 0038fb4 Compare September 19, 2017 18:48
@idimopoulos
Copy link
Contributor Author

Regarding the fact that I am returning the condition without throwing an error or an exception:
Under normal circumstances there should be an error/warning/exception thrown if there is an unmapped field attempted to be added in the query. The reason that I am not doing this is that unlike mysql, we are querying the for the entities in the deleteBeforeInsert method. In that case, if an invalid field is added to the RdfEntity['create'] then there will be an invalid error thrown as normally the value should just be ignored.

This should also be handled in issue #8. The create method should filter invalid values.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant