Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve picasso & avatars #3174

Merged
merged 36 commits into from
Jan 24, 2023
Merged

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Nov 19, 2022

Closes #2965

I've testet the avatars again and think it is better to just use text, as it gets too nervous, unsteady really fast.

If we really wanted reliable avatars, I'd want them to always be in the right bottom for consistency. But I'd want them to float (the real way). This is currently not possible with css only.

Also I've added a reminder that drag and drop is only allowed in unlocked mode. (Comes up if you drag the v-calendar one hour)

what after before
picasso readonly Bildschirmfoto 2022-11-20 um 13 50 46 Bildschirmfoto 2022-11-20 um 13 35 27
picasso editable Bildschirmfoto 2022-11-20 um 13 51 16 Bildschirmfoto 2022-11-20 um 13 36 14
picasso reminder Bildschirmfoto 2022-11-20 um 13 41 35
activity responsibles Bildschirmfoto 2022-11-20 um 13 46 18 Bildschirmfoto 2022-11-20 um 13 46 47

@manuelmeister manuelmeister marked this pull request as ready for review November 19, 2022 22:20
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pills in the multiselect look very nice!

If you are refining the locking behaviour and adding hints etc., could you also resolve the following point from #3144:

  • Picasso: Even when unlocked, schedule entries can't be moved [video]

common/helpers/interpolation.js Show resolved Hide resolved
frontend/src/components/dashboard/AvatarRow.vue Outdated Show resolved Hide resolved
frontend/src/components/dashboard/AvatarRow.vue Outdated Show resolved Hide resolved
frontend/src/components/user/UserAvatar.vue Outdated Show resolved Hide resolved
frontend/src/locales/de.json Outdated Show resolved Hide resolved
frontend/src/components/program/picasso/Picasso.vue Outdated Show resolved Hide resolved
frontend/src/scss/global.scss Outdated Show resolved Hide resolved
frontend/src/scss/global.scss Show resolved Hide resolved
frontend/src/views/camp/CampProgram.vue Show resolved Hide resolved
@manuelmeister
Copy link
Member Author

@carlobeltrame I'd prefer to not implement touch with this PR. But I could add an additional reminder.

@carlobeltrame
Copy link
Member

@carlobeltrame I'd prefer to not implement touch with this PR. But I could add an additional reminder.

Oh okay, that's fine. I was thinking more about hiding the lock icon and disabling the new reminders on mobile. But if you think it's possible to properly implement touch drag operations on a mobile device, that would be even better of course, and can be done separately.

@manuelmeister
Copy link
Member Author

Yes, otherwise you can't change day responsibles on mobile.

@usu usu added deploy! Creates a feature branch deployment for this PR and removed deploy! Creates a feature branch deployment for this PR labels Nov 27, 2022
@manuelmeister manuelmeister added UX/UI type: Frontend deploy! Creates a feature branch deployment for this PR labels Nov 27, 2022
@manuelmeister
Copy link
Member Author

@carlobeltrame I tried to add event listeners on touchstart, … but I could not get it to work. I've added it in #3144

Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually looks good to me 👍

A few questions and comments below. I'm also fine with merging and cleaning up in follow-up commits.

@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for ecamp3-frontend-preview ready!

Name Link
🔨 Latest commit 55a687c
🔍 Latest deploy log https://app.netlify.com/sites/ecamp3-frontend-preview/deploys/63d069f94d8b0c000b9c375a
😎 Deploy Preview https://deploy-preview-3174--ecamp3-frontend-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@usu usu removed the deploy! Creates a feature branch deployment for this PR label Dec 28, 2022
Display avatars automatically at a min width of 200 px
@manuelmeister
Copy link
Member Author

@carlobeltrame could you have another look at it?

@manuelmeister manuelmeister added this to the MVP (v3.0) milestone Jan 7, 2023
@manuelmeister manuelmeister modified the milestones: MVP (v3.0), Closed Beta Jan 24, 2023
@pmattmann pmattmann merged commit 7dadcf0 into ecamp:devel Jan 24, 2023
@manuelmeister manuelmeister deleted the improve/picasso branch January 24, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants