-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve picasso & avatars #3174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frontend/src/components/program/picasso/ScheduleEntryResponsibles.vue
Outdated
Show resolved
Hide resolved
@carlobeltrame I'd prefer to not implement touch with this PR. But I could add an additional reminder. |
Oh okay, that's fine. I was thinking more about hiding the lock icon and disabling the new reminders on mobile. But if you think it's possible to properly implement touch drag operations on a mobile device, that would be even better of course, and can be done separately. |
Yes, otherwise you can't change day responsibles on mobile. |
Move more schedule entry specific logic to picasso entry
@carlobeltrame I tried to add event listeners on touchstart, … but I could not get it to work. I've added it in #3144 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually looks good to me 👍
A few questions and comments below. I'm also fine with merging and cleaning up in follow-up commits.
✅ Deploy Preview for ecamp3-frontend-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Stay longer in mobile view, as it more space-saving for the picasso overview
Implemented possible requested changes
Display avatars automatically at a min width of 200 px
@carlobeltrame could you have another look at it? |
Closes #2965
I've testet the avatars again and think it is better to just use text, as it gets too nervous, unsteady really fast.
If we really wanted reliable avatars, I'd want them to always be in the right bottom for consistency. But I'd want them to float (the real way). This is currently not possible with css only.
Also I've added a reminder that drag and drop is only allowed in unlocked mode. (Comes up if you drag the v-calendar one hour)