Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: use vite's mechanism for env variables to fill window.envir… #3268

Merged
merged 11 commits into from
Sep 17, 2023
Merged

frontend: use vite's mechanism for env variables to fill window.envir… #3268

merged 11 commits into from
Sep 17, 2023

Commits on Sep 17, 2023

  1. frontend: minimal switch to vitest 

    Not all tests are running
    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    9c5ff93 View commit details
    Browse the repository at this point in the history

  2. frontend: add .vue to imports for tests 

    Because vitest cannot resolve the files if there is no extension.
And update snapshots.
    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    1ba2cbd View commit details
    Browse the repository at this point in the history

  3. frontend: move method debouncedSave to methods where it belongs 

    Vitest said correctly that this method does not exist.
    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    4e408be View commit details
    Browse the repository at this point in the history

  4. frontend: fix ApiWrapper.spec.js for vitests

    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    24dc4bf View commit details
    Browse the repository at this point in the history

  5. ApiMock.js: replace jest with vi

    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    60c9a75 View commit details
    Browse the repository at this point in the history

  6. Admin.spec.js: adapt to vitest 

    Let the test helpers create the store, just provide a json.
This fixes Error: [vuex] getters should be function but "getters.getLoggedInUser" is {"_meta":{"self":"/users/17d341a80579"}}.

Write the stubs in camel case

And simplify a little.
    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f6ebc07 View commit details
    Browse the repository at this point in the history

  7. frontend: delete RichText tests 

    Because i could not get them to run with vitest.
The error i could not resolve:
 FAIL  src/components/form/api/__tests__/ApiRichtext.spec.js > An ApiRichtext > updates state if value in store is refreshed and has new value
TypeError: tippy is not a function
 ❯ BubbleMenuView.createTooltip node_modules/@tiptap/extension-bubble-menu/src/bubble-menu-plugin.ts:141:18
 ❯ BubbleMenuView.updateHandler node_modules/@tiptap/extension-bubble-menu/src/bubble-menu-plugin.ts:200:10
 ❯ BubbleMenuView.update node_modules/@tiptap/extension-bubble-menu/src/bubble-menu-plugin.ts:170:10
 ❯ EditorView.updatePluginViews node_modules/prosemirror-view/dist/index.js:5262:32
 ❯ EditorView.updateStateInner node_modules/prosemirror-view/dist/index.js:5211:14
 ❯ EditorView.updateState node_modules/prosemirror-view/dist/index.js:5142:14
 ❯ Editor.dispatchTransaction node_modules/@tiptap/core/src/Editor.ts:344:15
 ❯ EditorView.dispatch node_modules/prosemirror-view/dist/index.js:5471:33
 ❯ Object.method [as setContent] node_modules/@tiptap/core/src/CommandManager.ts:42:18
 ❯ VueComponent.value src/components/form/tiptap/TiptapEditor.vue:174:1
    172|       // of the input field
    173|       if (val !== this.html) {
    174|         this.editor.commands.setContent(val)
       | ^
    175|       }
    176|     },
    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    6902330 View commit details
    Browse the repository at this point in the history

  8. auth.spec.js: reduce time for logout test 

    router.push takes ca 2 seconds, which is too long for a unit tests.
Thus we mock router.push and router.resolve.
Then store.replace does not work anymore, thus we use vi.importActual
to make sure not the somehow mocked store is used.
    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    e00cf78 View commit details
    Browse the repository at this point in the history

  9. frontend: configure coverage for vitest

    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    9a63a67 View commit details
    Browse the repository at this point in the history

  10. common: make matchingTranslationKeys.spec.js run directory independen… 

    …t for vitest

Mocking seems a little difficult with vitest.
If we keep the /app, the tests work in the docker container, but not
when running the tests with a local interpreter.
    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    a7cc8fd View commit details
    Browse the repository at this point in the history

  11. frontend: use vite's mechanism for env variables to fill window.envir… 

    …onment

That we don't have locally cached environment.js files breaking the development setup.
Sadly we still use vue-cli to run our tests, so there the vite mechanism does
not work and we have to maintain one additional environment.js.

In production, we compose the environment.js anyway in the configmap, thus we don't
have to consider the production case in dev-environment.js.

Now we can also remove the check in index.html.
In a production environment, you have to check yourself that you have all the needed configurations
set.

closes ecamp#3267
    @BacLuc
    BacLuc committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    bb570c7 View commit details
    Browse the repository at this point in the history