Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: wait for autofocus to focus the email field in login.cy.js #3639

Closed
wants to merge 1 commit into from
Closed

e2e: wait for autofocus to focus the email field in login.cy.js #3639

wants to merge 1 commit into from

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Jul 31, 2023

No description provided.

@BacLuc
Copy link
Contributor Author

BacLuc commented Aug 2, 2023

Sadly this wasn't it.

With the change: https://github.com/BacLuc/ecamp3/actions/runs/5724067702
The test run failed 3/50 times because of the focused field switch.
And some other failed because of cache misses or node-gyp problems

Without the change: https://github.com/BacLuc/ecamp3/actions/runs/5724067702
The test run failed 3/50 times because of the focused field switch..
And some other failed because of cache misses or node-gyp problems.

But the other browsers did not have this problem, and locally this problem does not occur too.
-> maybe disable the electron tests?

@BacLuc BacLuc closed this Aug 2, 2023
@BacLuc BacLuc deleted the e2e-improve-stability-electron branch December 23, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlobeltrame carlobeltrame carlobeltrame approved these changes

@usu usu Awaiting requested review from usu

@manuelmeister manuelmeister Awaiting requested review from manuelmeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BacLuc @carlobeltrame