Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display responsibilities count on teampage #3675

Conversation

DeNic0la
Copy link
Collaborator

@DeNic0la DeNic0la commented Aug 6, 2023

this fixes #3493

Display on List:
ECamp_01

Display on Edit:
ECamp_02

The Chips contain Links to the Dashboard with filters for the activities based on changes to be implemented with #3406 (not merged, therefore not working)

@DeNic0la DeNic0la marked this pull request as ready for review August 9, 2023 16:10
@DeNic0la
Copy link
Collaborator Author

DeNic0la commented Aug 9, 2023

I haven't looked into the tests, since I would like the UI/UX approved before spending time on that.
Let me know what you think @manuelmeister (or anyone from @ecampcore )

@DeNic0la
Copy link
Collaborator Author

DeNic0la commented Aug 9, 2023

I added some SQLs for activity_responsible since there were not that many entries before. Would be nice if someone could add the deploy tag

@usu usu added the Meeting Discuss Am nächsten Core-Meeting besprechen label Aug 14, 2023
@pmattmann pmattmann added the deploy! Creates a feature branch deployment for this PR label Aug 15, 2023
@pmattmann
Copy link
Member

I can understand the intention that one would like to see, for example, who has already comitted to how many blocks.
However, if I were to explicitly search for this function, I probably wouldn't search on the team overview first.
That the details are 'hidden' in the edit dialog I find all the more strange. Especially since the edit dialog is not accessible to everyone in terms of permissions.

Counter-suggestion:
A la Digitec filters. These show in each case how many results are to be expected:

image

@DeNic0la
Copy link
Collaborator Author

I think the chips on the edit dialogue are helpful for a manager since it's their job to keep in mind who has which responsibilities.

How about just adding @pmattmann suggestion as an additional feature and keeping the count on the team page?

@pmattmann
Copy link
Member

How about just adding @pmattmann suggestion as an additional feature and keeping the count on the team page

I would also use the dashboard as a manager. An edit dialog as a source for information doesn't sound like good practice to me. In the end, someone changes the role of a user just because he wanted to look something up.

@DeNic0la
Copy link
Collaborator Author

An edit dialog as a source for information doesn't sound like good practice to me. In the end, someone changes the role of a user just because he wanted to look something up.

Fair point. However, i like the way the responsibilities are grouped by category and think it is very useful. I don't like the Idea of removing it completely. Any Idea what to do with that or where to move that to?

@pmattmann
Copy link
Member

Hey @DeNic0la
First of all - big thanks for your contributions. We are very happy to see your motivation.

Yesterday evening we met in the Core Team and looked at your PR among many other points.

Probably there were some misunderstandings here. We captured the issue #3493 as a thought starter. However, after some exchange we came to the conclusion that the Issue was not ready for implementation. We will try to label the issues better in the future, and if the issue is unclear, it may make sense to outline it in prose before spending a lot of time on implementation.

Conclusion:
The Teams page is an administration page. The idea to show the responsibilities of a user comes from the 'exit scenario'. It should answer the question, which responsibilities could go down, if someone leaves a camp. The actual overview, who carries which responsibility, this we see much more on the dashboard - where also all have equal access.

Team-Page:
Maybe we will add a warning when a user deactivates (not ready to speak)
image
Such a warning could go beyond activities - and include material lists or day-responsibilities. We don't want to overwhelm the team page with all this information.

Dashboard:
Filter display à la Digitec currently convinces us the most. Alternatively, I could imagine that we show aggregates on the dashboard (according to current filtering).
Attention - this is a spontaneous idea - and also needs additional considerations. I'm curious to hear your thoughts on this.

Outlook:
I tried to find your mail address - or any other way to contact you. However, I failed. Can you please write to us at contact. I would like to send you the date of the next PBS hackaton. We would be happy to meet you in person.

@pmattmann pmattmann removed the Meeting Discuss Am nächsten Core-Meeting besprechen label Aug 16, 2023
@DeNic0la
Copy link
Collaborator Author

Hey @pmattmann, I contacted you over the contact form.
Didn't get a confirmation mail so if you didn't get it let me know.

@DeNic0la DeNic0la closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team page: Find a way to display activities responsibilites count
3 participants