-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: update dev-data #3701
api: update dev-data #3701
Conversation
BacLuc
commented
Aug 13, 2023
- recreated the camps from scratch that:
- the materiallists are attached to the campcollaborations
- add dayresponsibles for each day
- add activityresponsibles for most activities
- add more materialitems
- add more content to the Harry Potter Lager, that the PDF is now 40 pages long.
- use a guessable email address for the users: e.g. Castor has now the email address [email protected].
- all activites use now the layout better suited for printing of @carlobeltrame
- Switch to german as default language for Bi-Pi, because that is the language most of our users use. Like this we see faster if something does not work with the german translation.
- recreated the camps from scratch that: - the materiallists are attached to the campcollaborations - add dayresponsibles for each day - add activityresponsibles for most activities - add more materialitems - add more content to the Harry Potter Lager, that the PDF is now 40 pages long. - use a guessable email address for the users: e.g. Castor has now the email address [email protected]. - all activites use now the layout better suited for printing of @carlobeltrame - Switch to german as default language for Bi-Pi, because that is the language most of our users use. Like this we see faster if something does not work with the german translation.
@DeNic0la |
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
I can understand the argument for this. On the other side, it makes it a bit less accessible for non German speaking developers. I now need to understand German (or translate) to understand what is going on in the e2e tests. At the moment not super dramatic, as our e2e tests are very limited. But might be an issue, if we start to use e2e tests more excessively. |
The topic of accessibility for non-German developers is a core team decision so I am not gonna argue with that, but I think the Dev-Data has a bigger impact on that than the e2e tests (and most of the dev-data is German). Regarding the e2e tests, I would propose to load the Translations and use the strings from the Translations. This is 'language-neutral' and doesn't break on translation changes. I added a e2e test in #3406 wich would also require translation: @BacLuc https://github.com/ecamp/ecamp3/blob/5d8277f75f81942baf353108bd15c00b10f1a685/e2e/specs/persistDashboardFilter.cy.js Currently, it contains mixed languages like
This is already on the devel branch and merging this (#3701 ) PR would cause future e2e tests to fail. |
ok, you are right, there dev data also makes the development german.
I lost a similar argument here #3340 (sadly i did not write down my argumentation).
I merged and fixed the tests. |