Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renovate config warnings #5244

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented May 26, 2024

See the single commits for more info

@BacLuc BacLuc force-pushed the fix-renovate-config-warnings branch from 9ba9e62 to f156d9b Compare May 26, 2024 15:47
Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the renovate logs, I can see another config warning:

image

Should we try to fix this as well in this PR?

@@ -1,6 +1,7 @@
{
"extends": [
"config:base",
"mergeConfidence:all-badges",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?
I understood, this would only need to be enabled for self-hosting renovate: https://docs.renovatebot.com/merge-confidence/#enabling-and-disabling

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The massaged config contains the values that are in fact used.
One way is to make the config transparent. e.g. when i run renovate locally to test renovate, then this preset is not set.
But in both cases i would want the same output.
But it is not important, i can also drop this commit

@BacLuc
Copy link
Contributor Author

BacLuc commented Jun 26, 2024

@carlobeltrame
@usu
@pmattmann
ping
there are other changes in the pipeline

@BacLuc BacLuc force-pushed the fix-renovate-config-warnings branch from f156d9b to 02b2c1a Compare July 2, 2024 19:40
@BacLuc BacLuc enabled auto-merge July 2, 2024 19:41
@BacLuc BacLuc added this pull request to the merge queue Jul 2, 2024
Merged via the queue into ecamp:devel with commit c5a6895 Jul 2, 2024
28 checks passed
@BacLuc BacLuc deleted the fix-renovate-config-warnings branch July 2, 2024 19:45
@BacLuc BacLuc mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants