Expand caching #6834
Open
Expand caching #6834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we rolled out caching, we should use it locally to maybe detect the error with caching earlier.
Like this not all the urls end up in one big regex. Add the tags to all requests in ResponseTagger, because they are anyway generated, and not having all urls in one big regex has more worth than only adding the tags to the cached routes.
It seems this is an endpoint were a lot of request time is lost. The days also don't change that often.
It gets hit quite often, and only changes after the deployment. This may pose a challenge during development.
That it can be cached.
BacLuc
force-pushed
the
expand-caching
branch
from
69144e0 to
e2dd24c
Compare
We have the EndpointPerformanceTest which measures this.
BacLuc
force-pushed
the
expand-caching
branch
from
e2dd24c to
270d2c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.