Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export from a MFA-enabled connexion not specifying the database name #11

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

Greybird
Copy link
Contributor

This should fix the issue reported in #9 (incorrectly interpreted by myself as lack of MFA support) and #6 (comment #6 (comment) is actually giving a crucial information in how to fix).

I did the following tests:

Credentials Database Before fix After fix
SQL login <Default> ✔️ ✔️
SQL login provided ✔️ ✔️
MFA <Default> ✔️
MFA provided ✔️ ✔️

Hope this helps!

@ecirpnaes ecirpnaes merged commit 7a9190a into ecirpnaes:master Oct 11, 2020
@ecirpnaes
Copy link
Owner

This looks good

@ecirpnaes
Copy link
Owner

Thanks for the fix. Merged to release. Here is the link to the latest install file in case you need it.
https://github.com/ecirpnaes/SimpleDataScripter/releases/download/0.1.5/simple-data-scripter-0.1.5.vsix
It will be a while before the Azure team pushes a new build so the extension won't get updated in the Marketplace for a bit.

@Greybird Greybird deleted the bugfix/mfa-export branch October 12, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants