This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
CW Issue #2520: Support disabling keyring access #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this ?
What does this PR do ?
Allows users to disable keyring access through a preference if they do not have keyring software installed or the keyring can't be accessed. If Codewind start fails because there is no keyring or it can't be accessed then the user is prompted at that time to disable keyring access so they can start Codewind.
Which issue(s) does this PR fix ?
Link to the Codewind repository issue(s) this PR fixes or references:
eclipse-archived/codewind#2520
Does this PR require a documentation change ?
Yes
Any special notes for your reviewer ?
No