test: make test clearer

Signed-off-by: Richard Waller <[email protected]>
eclipse-archived · Apr 23, 2020 · aaa0848 · aaa0848
1 parent e592efb
commit aaa0848
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/test/src/API/templates/templates.test.js b/test/src/API/templates/templates.test.js
@@ -113,17 +113,12 @@ describe('Template API tests', function() {
             });
             describe('a duplicate url', function() {
                 it('should return 400', async function() {
-                    // Arrange
-                    const res = await getTemplateRepos();
-                    const originalTemplateRepos = res.body;
-                    const duplicateRepoUrl = originalTemplateRepos[0].url;
-                    // Act
-                    const duplicateUrlRes = await addTemplateRepo({
-                        url: duplicateRepoUrl,
+                    const { body: [existingRepo] } = await getTemplateRepos();
+                    const res = await addTemplateRepo({
+                        url: existingRepo.url,
                         description: 'duplicate url',
                     });
-                    // Assert
-                    duplicateUrlRes.should.have.status(400, duplicateUrlRes.text);
+                    res.should.have.status(400, res.text);
                 });
             });
             describe('a valid url that does not point to an index.json', function() {