[#410] Evolve options API without bumping major version every time #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ruspl-afed
commented
Feb 19, 2025
ruspl-afed
commented
- extract predefined preference metadata to another "noimplement" interface
ruspl-afed
commented
Feb 19, 2025
| true, // | ||
| LspEditorUiMessages.LspEditorPreferencePage_enable_tidy, // | ||
| LspEditorUiMessages.LspEditorPreferencePage_enable_tidy); | ||
| interface Predefined { |
There was a problem hiding this comment.
@jonahgraham this should reduce API breakage to a minimum.
WDYT?
There was a problem hiding this comment.
Did you try API tools?
To repeat my other comment, I think having breaking API according to API tools is fine, just we should document that it is ok to add filters. I'm not sure restructuring the whole code like this is needed, but I don't have an objection.
ghentschke
approved these changes
Feb 19, 2025
| true, // | ||
| LspEditorUiMessages.LspEditorPreferencePage_enable_tidy, // | ||
| LspEditorUiMessages.LspEditorPreferencePage_enable_tidy); | ||
| interface Predefined { |
…ery time * extract predefined preference metadata to another "noimplement" interface
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.