Check for clangd in MinGW installation

[jld01]

Relates to #424

[jld01]

@jonahgraham and @ghentschke, this patch attempts to find clangd in the MinGW installation known to CDT (eg MSYS2 UCRT64) if it was not found on the system PATH. Note that:

• MinGW.getMinGWHome() returns null efficiently if not running on a Windows host
• The MinGW class is not API at present

Please feel free to use or adapt this as you see fit.

[jonahgraham]

@jonahgraham and @ghentschke, this patch attempts to find clangd in the MinGW installation known to CDT (eg MSYS2 UCRT64) if it was not found on the system PATH.

Thanks @jld01 for this - I was hoping something like this would be possible with MinGW class and your implementation is simpler and more straightforward than I expected :-)

Note that:

• MinGW.getMinGWHome() returns null efficiently if not running on a Windows host

👍

• The MinGW class is not API at present

In my view CDT LSP is part of CDT so using CDT internal code is not violating any API contract. Ideally an x-friends should be added on org.eclipse.cdt.internal.core at some point to remove warning.

Please feel free to use or adapt this as you see fit.

Thanks.

This LGTM, but I haven't run it on Windows yet. @ghentschke I am hoping you can review to verify that this is the best place to inject the MinGW's location.

[jld01]

Note that the MinGW class performs various checks to find an installation containing gcc. So this code is helpful only if gcc and clangd are in the same folder. Otherwise, clangd will not be found and the code is harmless.

We can improve on this, but time is short for 12.0.0 and the code provides a good improvement where a new user is following the Before you begin help page to install tools.

[ghentschke]

LGTM

[ghentschke]

Does it also work for MSYS2?

[jld01]

Does it also work for MSYS2?

Yes, the CDT MinGW class will detect MinGW tools installed via the MSYS2 package manager. This is the use case of primary interest.