Fix #436 Search .clang-format file in parent folders, before creating it #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re creating it
jonahgraham
reviewed
Feb 25, 2025
There was a problem hiding this comment.
@travkin79 Thanks for putting this together. I think this is generally the right idea and avoiding creating clang format files in this case is a good idea.
I see this is only a draft at the moment. I did a quick review because I would really like to get this merged by end of the day Wednesday, assuming no objection.
Let me know what I can do to make this happen.
| private IFileStore findClangFormatFileInParentFolders(IProject project) { | ||
| IFileStore currentDirStore = EFS.getLocalFileSystem().getStore(project.getLocation()); | ||
| IFileStore clangFormatFileStore = currentDirStore.getChild(format_file); | ||
| while (!clangFormatFileStore.fetchInfo().exists() && currentDirStore.getParent().fetchInfo().exists()) { |
There was a problem hiding this comment.
I think there is an NPE here? as getParent can return null when the root is reached
|
|
||
| @Override | ||
| public void performDone(IJobChangeEvent event) { | ||
| if (openFile) { |
There was a problem hiding this comment.
Can this if openFile guard be moved out to prevent creating this job in the first place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a .clang-format file for each project, CDT LSP now would check if there is a .clang-format file in some of the project's parent folders and use that. This way, multi-project directory structures (multi-project git repos) can offer common settings in their root folder that apply to all contained projects.