Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement for the workspace startup failure screen #1002

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Improvement for the workspace startup failure screen #1002

merged 3 commits into from
Nov 29, 2023

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Nov 24, 2023 •
edited
Loading

What does this PR do?

This PR updates:

  • failed workspace status indicator and status label;
  • workspace startup failure screen
    • to use warning icons and colors (if there are few options)
    • to add a link to edit the workspace object (in OpenShift console)
Workspace startup page

Screenshot 2023-11-23 at 17 03 10

Workspaces list page

Screenshot 2023-11-23 at 17 03 23

Workspace details page

Screenshot 2023-11-23 at 17 03 29

What issues does this PR fix or reference?

resolves eclipse-che/che#22640
fixes eclipse-che/che#22694

Is it tested? How?

  1. Deploy Eclipse Che and use the dashboard image from this PR: quay.io/eclipse/che-dashboard:pr-1002

    kubectl patch -n eclipse-che checluster/eclipse-che --type=json -p="[{\"op\": \"replace\", \"path\": \"/spec/components/dashboard\", \"value\": {deployment: {containers: [{image: \"quay.io/eclipse/che-dashboard:pr-1002\", name: che-dashboard}]}}}]"

  2. Run a workspace that fails on startup, or create one using this devfile:

    schemaVersion: 2.1.0
metadata:
  name: wksp
  generateName: wksp-
components:
  - name: should-fail
    container:
      image: non-existing-image-name

  3. Wait until workspace fails.

@akurinnoy akurinnoy self-assigned this Nov 24, 2023
@che-bot
Copy link
Contributor

che-bot commented Nov 24, 2023

Click here to review and test in web IDE: Contribute

@github-actions GitHub Actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1002

@akurinnoy
Copy link
Contributor Author

/retest

4 similar comments
@ibuziuk
Copy link
Member

ibuziuk commented Nov 24, 2023

/retest

@ibuziuk
Copy link
Member

ibuziuk commented Nov 24, 2023

/retest

@akurinnoy
Copy link
Contributor Author

/retest

@ibuziuk
Copy link
Member

ibuziuk commented Nov 27, 2023

/retest

olexii4
olexii4 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected.
Знімок екрана 2023-11-27 о 15 50 30
Знімок екрана 2023-11-27 о 16 24 26

@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2023
@akurinnoy
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 28, 2023

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path fffd8e2 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@artaleks9
Copy link
Contributor

@akurinnoy
Artifacts of Openshift-CI showed, the dashboard-happy-path test is failed due two reasons:

  1. it seems, the infrastructure problem, when the test workspace couldn't run, see the scrrenshot

screenshot-Wait_workspace_readiness

  1. all test-steps are done, excluding the last one - stop and delete the test woekspace with the error:
Stop the workspace by UI:
     TimeoutError: Waiting for element to be located By(xpath, //tr[td//a[text()='quarkus-api-example-mg59']]//span[@data-testid='workspace-status-indicator']//*[local-name()='svg' and @fill='green'])

See screenshot:

screenshot-Stop_the_workspace_by_UI

My guess, the locator was changed, and need to fix up:
https://github.com/eclipse/che/blob/main/tests/e2e/pageobjects/dashboard/Workspaces.ts#L72 -->
https://github.com/eclipse/che/blob/main/tests/e2e/pageobjects/dashboard/Workspaces.ts#L220

@akurinnoy akurinnoy merged commit 43e68c8 into main Nov 29, 2023
10 checks passed
@akurinnoy akurinnoy deleted the workspace-startup-fails branch November 29, 2023 08:07
@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/408: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5423: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5296: Console, Changes, Git Data

@akurinnoy akurinnoy mentioned this pull request Nov 29, 2023
Closed
@devstudio-release
Copy link

Build 3.11 :: push-latest-container-to-quay_3.x/3801: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5296: SUCCESS

dashboard : 3.x :: Build 57269141 : quay.io/devspaces/dashboard-rhel8:3.11-33
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3801 triggered

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5059: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/408: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5423 triggered

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2337: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5426: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5299: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: push-latest-container-to-quay_3.x/3804: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2222: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5299: SUCCESS

devspaces-operator-bundle : 3.x :: Build 57269403 : quay.io/devspaces/devspaces-operator-bundle:3.11-112
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3804 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.11-46
- quay.io/devspaces/configbump-rhel8:3.11-7
- quay.io/devspaces/dashboard-rhel8:3.11-34
- quay.io/devspaces/devfileregistry-rhel8:3.11-25
- quay.io/devspaces/devspaces-rhel8-operator:3.11-13
- quay.io/devspaces/idea-rhel8:3.11-13
- quay.io/devspaces/pluginregistry-rhel8:3.11-7
- quay.io/devspaces/server-rhel8:3.11-18
- quay.io/devspaces/traefik-rhel8:3.11-4
- quay.io/devspaces/udi-rhel8:3.11-11
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202311021630.p0.gb17014f.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202311021630.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5426: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5299 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2337: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5426 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1603: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5059: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2337 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1603: SUCCESS

3.11.0-CI

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2222: SUCCESS

3.11
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.11-112
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-630445-533291-s390x
  + quay.io/devspaces/iib:3.11-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.11-v4.13-630443-533286-s390x
  + quay.io/devspaces/iib:3.11-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.11-v4.12-630663-533281-s390x
  + quay.io/devspaces/iib:3.11-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.11-v4.11-630660-533277-s390x
  + quay.io/devspaces/iib:3.11-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-630445-533291-x86_64
  + quay.io/devspaces/iib:3.11-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-630443-533286-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-630663-533281-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-630660-533277-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-630445-533291-ppc64le
  + quay.io/devspaces/iib:3.11-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-630443-533286-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-630663-533281-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-630660-533277-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexii4 olexii4 olexii4 approved these changes

@ibuziuk ibuziuk ibuziuk approved these changes

Assignees

@ibuziuk ibuziuk

@olexii4 olexii4

@akurinnoy akurinnoy

Labels
lgtm
Projects
None yet
Milestone
No milestone
6 participants
@akurinnoy @che-bot @ibuziuk @artaleks9 @devstudio-release @olexii4