Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide kubectl patch command on PR check #1005

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This pull request extends the PR check comment to provide the kubectl patch command. This command can be used then in the Is it tested? How? section in the PR description.

Screenshot 2023-11-27 at 18 07 48

@che-bot
Copy link
Contributor

che-bot commented Nov 28, 2023

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1005

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1005", name: che-dashboard}]}}]"

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26cde8b) 86.50% compared to head (a08a6f3) 86.50%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1005   +/-   ##
=======================================
  Coverage   86.50%   86.50%           
=======================================
  Files         383      383           
  Lines       39396    39396           
  Branches     2580     2580           
=======================================
  Hits        34078    34078           
  Misses       5292     5292           
  Partials       26       26           
Flag Coverage Δ
unittests 86.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit 89c84f6 into main Nov 29, 2023
12 checks passed
@akurinnoy akurinnoy deleted the improve-pr-check branch November 29, 2023 08:06
@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/407: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/407: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5422 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5060: UNSTABLE

No new images detected: nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants