Change the token data input type to password in the add/edit PAT popup #1007
Conversation
vinokurig
requested review from
akurinnoy,
olexii4 and
ibuziuk
as code owners
|
Click here to review and test in web IDE: |
There was a problem hiding this comment.
👍 do we have other inputs on UD that should use the password mask e.g. SSH etc.
cc: @olexii4 @akurinnoy
|
@vinokurig Tests should be fixed too. |
|
@vinokurig: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
- Coverage 86.50% 86.40% -0.10%
==========================================
Files 383 385 +2
Lines 39396 39369 -27
Branches 2580 2584 +4
==========================================
- Hits 34078 34016 -62
- Misses 5292 5328 +36
+ Partials 26 25 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1007 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1007", name: che-dashboard}]}}]" |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.11 :: dashboard_3.x/410: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5431: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3807: Console, Changes, Git Data |
|
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5305: dashboard : 3.x :: Build 57275797 : quay.io/devspaces/dashboard-rhel8:3.11-36 |
|
Build 3.11 :: update-digests_3.x/5064: Console, Changes, Git Data |
|
Build 3.11 :: dashboard_3.x/410: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5431 triggered |
|
Build 3.11 :: operator-bundle_3.x/2339: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5432: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3808: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5432: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5306 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.11 :: operator-bundle_3.x/2339: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5432 triggered |
|
Build 3.11 :: copyIIBsToQuay/2224: Console, Changes, Git Data |
|
Build 3.11 :: update-digests_3.x/5064: Detected new images: rebuild operator-bundle |
|
Build 3.11 :: dsc_3.x/1605: Console, Changes, Git Data |
|
Build 3.11 :: dsc_3.x/1605: 3.11.0-CI |
What does this PR do?
Hide the token input in the PAT popup with a password input type:
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-5335
Is it tested? How?
Go to the User Preferences -> Personal Access Tokens tab and add a new token or edit existed.
See: the token input is hidden.
Release Notes
Docs PR