fix: getting pluginRegistry #1009
Conversation
|
Click here to review and test in web IDE: |
Signed-off-by: Oleksii Orel <[email protected]>
|
@olexii4: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1009 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1009", name: che-dashboard}]}}]" |
| @@ -104,16 +104,18 @@ describe('Dashboard bootstrap', () => { | |||
| expect(mockGet).toHaveBeenCalledWith('/dashboard/api/namespace/test-che/events', undefined); | |||
| expect(mockGet).toHaveBeenCalledWith('/dashboard/api/namespace/test-che/pods', undefined); | |||
| expect(mockGet).toHaveBeenCalledWith('/dashboard/api/cluster-config'); | |||
| // todo: figure out why ws tests fail on github actions | |||
There was a problem hiding this comment.
just wondering if we started to have this failures on this PR or this happened before ?
There was a problem hiding this comment.
We have had this failure before(time to time). However, I can not reproduce this error locally and fix it.
There was a problem hiding this comment.
This test fails sometimes when running on GH, and usually on the second run it passes.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.11 :: dashboard_3.x/413: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5456: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3821: Console, Changes, Git Data |
|
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5331: dashboard : 3.x :: Build 57308133 : quay.io/devspaces/dashboard-rhel8:3.11-38 |
|
Build 3.11 :: update-digests_3.x/5079: Console, Changes, Git Data |
|
Build 3.11 :: dashboard_3.x/413: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5456 triggered |
|
Build 3.11 :: operator-bundle_3.x/2346: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5457: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3822: Console, Changes, Git Data |
|
Build 3.11 :: copyIIBsToQuay/2231: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5457: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5332 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.11 :: operator-bundle_3.x/2346: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5457 triggered |
|
Build 3.11 :: dsc_3.x/1612: Console, Changes, Git Data |
|
Build 3.11 :: update-digests_3.x/5079: Detected new images: rebuild operator-bundle |
|
Build 3.11 :: dsc_3.x/1612: 3.11.0-CI |
What does this PR do?
This PR fixed the getPluginRegistry method.
What issues does this PR fix or reference?
fixes https://issues.redhat.com/browse/CRW-5346