Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #1013

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add unit tests #1013

merged 3 commits into from
Dec 4, 2023

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

Adds missing unit tests.

What issues does this PR fix or reference?

resolves eclipse-che/che#22117

@akurinnoy akurinnoy self-assigned this Dec 1, 2023
@che-bot
Copy link
Contributor

che-bot commented Dec 1, 2023

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Dec 1, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1013

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1013", name: che-dashboard}]}}]"

1 similar comment
Copy link

github-actions bot commented Dec 4, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1013

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1013", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Dec 4, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1013

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1013", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Dec 4, 2023

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path c40d3c4 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit d4ebc4a into main Dec 4, 2023
9 checks passed
@akurinnoy akurinnoy deleted the add-unit-test branch December 4, 2023 14:09
@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/418: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/418: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5491 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2252: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5494: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5373 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2359: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5494 triggered

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5122: SUCCESS

Detected new images: rebuild operator-bundle
* code
* server; /DS_CI/operator-bundle_3.x/2359 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1625: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1625: SUCCESS

3.11.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Increase coverage and stability of the tests for the che-dashboard
4 participants