-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade libs #1021
fix: upgrade libs #1021
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
+ Coverage 87.96% 87.99% +0.03%
==========================================
Files 383 383
Lines 39316 39305 -11
Branches 2607 2606 -1
==========================================
+ Hits 34585 34588 +3
+ Misses 4706 4692 -14
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1021 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1021", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/dashboard-backend/src/devworkspaceClient/services/__tests__/devWorkspaceApi.spec.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-backend/src/devworkspaceClient/services/helpers/devworkspace/constants.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/services/devfileApi/devfileApi.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Oleksii Kurinnyi <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1021 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1021", name: che-dashboard}]}}]" |
@olexii4 : hello, Build log@eclipse-che/dashboard-frontend: export 'V1alpha2DevWorkspaceStatus' (reexported as 'DevWorkspaceStatus') was not found in '@devfile/api' (module has no exports) Lerna (powered by Nx) Running target build for 2 projects failed
Could you please take a look? |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1021 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1021", name: che-dashboard}]}}]" |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1021 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1021", name: che-dashboard}]}}]" |
Build 3.12 :: dashboard_3.x/425: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5653: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/3922: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/5524: dashboard : 3.x :: Build 57625213 : quay.io/devspaces/dashboard-rhel8:3.12-6 |
Build 3.12 :: update-digests_3.x/5228: Console, Changes, Git Data |
Build 3.12 :: dashboard_3.x/425: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5653 triggered |
Build 3.12 :: operator-bundle_3.x/2441: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5654: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/3923: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5654: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5525 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.12 :: operator-bundle_3.x/2441: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5654 triggered |
Build 3.12 :: copyIIBsToQuay/2284: Console, Changes, Git Data |
Build 3.12 :: dsc_3.x/1644: Console, Changes, Git Data |
Build 3.12 :: update-digests_3.x/5228: Detected new images: rebuild operator-bundle |
Build 3.12 :: dsc_3.x/1644: 3.12.0-CI |
Build 3.12 :: dashboard_3.x/426: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5684: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/3952: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/5555: dashboard : 3.x :: Build 57681767 : quay.io/devspaces/dashboard-rhel8:3.12-7 |
Build 3.12 :: dashboard_3.x/426: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5684 triggered |
Build 3.12 :: update-digests_3.x/5263: Console, Changes, Git Data |
Build 3.12 :: update-digests_3.x/5263: No new images detected: nothing to do! |
What does this PR do?
This PR is needed to apply changes from
https://github.com/eclipse-che/che-devfile-registry/pull/804
.