Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade libs #1021

Merged
merged 7 commits into from
Dec 14, 2023
Merged

fix: upgrade libs #1021

merged 7 commits into from
Dec 14, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Dec 12, 2023

What does this PR do?

This PR is needed to apply changes from https://github.com/eclipse-che/che-devfile-registry/pull/804.

Signed-off-by: Oleksii Orel <[email protected]>
Copy link

openshift-ci bot commented Dec 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Dec 12, 2023

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 requested a review from svor December 12, 2023 05:03
@olexii4 olexii4 marked this pull request as ready for review December 12, 2023 15:27
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dc6121) 87.96% compared to head (765d1e2) 87.99%.
Report is 1 commits behind head on main.

❗ Current head 765d1e2 differs from pull request most recent head 1e3592a. Consider uploading reports for the commit 1e3592a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   87.96%   87.99%   +0.03%     
==========================================
  Files         383      383              
  Lines       39316    39305      -11     
  Branches     2607     2606       -1     
==========================================
+ Hits        34585    34588       +3     
+ Misses       4706     4692      -14     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1021

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1021", name: che-dashboard}]}}]"

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot removed the lgtm label Dec 13, 2023
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1021

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1021", name: che-dashboard}]}}]"

@dmytro-ndp
Copy link
Contributor

@olexii4 : hello,
smoke tests had failed on build of "che-dashboard-image-amd64" image: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/eclipse-che_che-dashboard/1021/pull-ci-eclipse-che-che-dashboard-main-v11-dashboard-happy-path/1734978937685020672

Build log

@eclipse-che/dashboard-frontend: export 'V1alpha2DevWorkspaceStatus' (reexported as 'DevWorkspaceStatus') was not found in '@devfile/api' (module has no exports)
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/index.ts 1:0-63 3:15-25
@eclipse-che/dashboard-frontend: @ ./src/store/Workspaces/devWorkspaces/index.ts 9:0-55 143:21-35 636:16-30
@eclipse-che/dashboard-frontend: @ ./src/store/index.ts
@eclipse-che/dashboard-frontend: @ ./src/store/configureStore.ts 5:0-29 8:11-19
@eclipse-che/dashboard-frontend: @ ./src/index.tsx 10:0-52 14:18-32
@eclipse-che/dashboard-frontend: ERROR in ../../node_modules/@devfile/api/dist/index.js 1:0-28
@eclipse-che/dashboard-frontend: Module not found: Error: Can't resolve './http/http' in '/dashboard/node_modules/@devfile/api/dist'
@eclipse-che/dashboard-frontend: Did you mean 'http.js'?
@eclipse-che/dashboard-frontend: BREAKING CHANGE: The request './http/http' failed to resolve only because it was resolved as fully specified
@eclipse-che/dashboard-frontend: (probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
@eclipse-che/dashboard-frontend: The extension in the request is mandatory for it to be fully specified.
@eclipse-che/dashboard-frontend: Add the extension to the request.
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/devfileApi.ts 1:0-80 1:0-80
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/index.ts 1:0-63 3:15-25
@eclipse-che/dashboard-frontend: @ ./src/store/Workspaces/devWorkspaces/index.ts 9:0-55 143:21-35 636:16-30
@eclipse-che/dashboard-frontend: @ ./src/store/index.ts
@eclipse-che/dashboard-frontend: @ ./src/store/configureStore.ts 5:0-29 8:11-19
@eclipse-che/dashboard-frontend: @ ./src/index.tsx 10:0-52 14:18-32
@eclipse-che/dashboard-frontend: ERROR in ../../node_modules/@devfile/api/dist/index.js 2:0-28
@eclipse-che/dashboard-frontend: Module not found: Error: Can't resolve './auth/auth' in '/dashboard/node_modules/@devfile/api/dist'
@eclipse-che/dashboard-frontend: Did you mean 'auth.js'?
@eclipse-che/dashboard-frontend: BREAKING CHANGE: The request './auth/auth' failed to resolve only because it was resolved as fully specified
@eclipse-che/dashboard-frontend: (probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
@eclipse-che/dashboard-frontend: The extension in the request is mandatory for it to be fully specified.
@eclipse-che/dashboard-frontend: Add the extension to the request.
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/devfileApi.ts 1:0-80 1:0-80
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/index.ts 1:0-63 3:15-25
@eclipse-che/dashboard-frontend: @ ./src/store/Workspaces/devWorkspaces/index.ts 9:0-55 143:21-35 636:16-30
@eclipse-che/dashboard-frontend: @ ./src/store/index.ts
@eclipse-che/dashboard-frontend: @ ./src/store/configureStore.ts 5:0-29 8:11-19
@eclipse-che/dashboard-frontend: @ ./src/index.tsx 10:0-52 14:18-32
@eclipse-che/dashboard-frontend: ERROR in ../../node_modules/@devfile/api/dist/index.js 3:0-29
@eclipse-che/dashboard-frontend: Module not found: Error: Can't resolve './models/all' in '/dashboard/node_modules/@devfile/api/dist'
@eclipse-che/dashboard-frontend: Did you mean 'all.js'?
@eclipse-che/dashboard-frontend: BREAKING CHANGE: The request './models/all' failed to resolve only because it was resolved as fully specified
@eclipse-che/dashboard-frontend: (probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
@eclipse-che/dashboard-frontend: The extension in the request is mandatory for it to be fully specified.
@eclipse-che/dashboard-frontend: Add the extension to the request.
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/devfileApi.ts 1:0-80 1:0-80
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/index.ts 1:0-63 3:15-25
@eclipse-che/dashboard-frontend: @ ./src/store/Workspaces/devWorkspaces/index.ts 9:0-55 143:21-35 636:16-30
@eclipse-che/dashboard-frontend: @ ./src/store/index.ts
@eclipse-che/dashboard-frontend: @ ./src/store/configureStore.ts 5:0-29 8:11-19
@eclipse-che/dashboard-frontend: @ ./src/index.tsx 10:0-52 14:18-32
@eclipse-che/dashboard-frontend: ERROR in ../../node_modules/@devfile/api/dist/index.js 4:0-54
@eclipse-che/dashboard-frontend: Module not found: Error: Can't resolve './configuration' in '/dashboard/node_modules/@devfile/api/dist'
@eclipse-che/dashboard-frontend: Did you mean 'configuration.js'?
@eclipse-che/dashboard-frontend: BREAKING CHANGE: The request './configuration' failed to resolve only because it was resolved as fully specified
@eclipse-che/dashboard-frontend: (probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
@eclipse-che/dashboard-frontend: The extension in the request is mandatory for it to be fully specified.
@eclipse-che/dashboard-frontend: Add the extension to the request.
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/devfileApi.ts 1:0-80 1:0-80
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/index.ts 1:0-63 3:15-25
@eclipse-che/dashboard-frontend: @ ./src/store/Workspaces/devWorkspaces/index.ts 9:0-55 143:21-35 636:16-30
@eclipse-che/dashboard-frontend: @ ./src/store/index.ts
@eclipse-che/dashboard-frontend: @ ./src/store/configureStore.ts 5:0-29 8:11-19
@eclipse-che/dashboard-frontend: @ ./src/index.tsx 10:0-52 14:18-32
@eclipse-che/dashboard-frontend: ERROR in ../../node_modules/@devfile/api/dist/index.js 5:0-33
@eclipse-che/dashboard-frontend: Module not found: Error: Can't resolve './apis/exception' in '/dashboard/node_modules/@devfile/api/dist'
@eclipse-che/dashboard-frontend: Did you mean 'exception.js'?
@eclipse-che/dashboard-frontend: BREAKING CHANGE: The request './apis/exception' failed to resolve only because it was resolved as fully specified
@eclipse-che/dashboard-frontend: (probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
@eclipse-che/dashboard-frontend: The extension in the request is mandatory for it to be fully specified.
@eclipse-che/dashboard-frontend: Add the extension to the request.
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/devfileApi.ts 1:0-80 1:0-80
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/index.ts 1:0-63 3:15-25
@eclipse-che/dashboard-frontend: @ ./src/store/Workspaces/devWorkspaces/index.ts 9:0-55 143:21-35 636:16-30
@eclipse-che/dashboard-frontend: @ ./src/store/index.ts
@eclipse-che/dashboard-frontend: @ ./src/store/configureStore.ts 5:0-29 8:11-19
@eclipse-che/dashboard-frontend: @ ./src/index.tsx 10:0-52 14:18-32
@eclipse-che/dashboard-frontend: ERROR in ../../node_modules/@devfile/api/dist/index.js 6:0-26
@eclipse-che/dashboard-frontend: Module not found: Error: Can't resolve './servers' in '/dashboard/node_modules/@devfile/api/dist'
@eclipse-che/dashboard-frontend: Did you mean 'servers.js'?
@eclipse-che/dashboard-frontend: BREAKING CHANGE: The request './servers' failed to resolve only because it was resolved as fully specified
@eclipse-che/dashboard-frontend: (probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
@eclipse-che/dashboard-frontend: The extension in the request is mandatory for it to be fully specified.
@eclipse-che/dashboard-frontend: Add the extension to the request.
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/devfileApi.ts 1:0-80 1:0-80
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/index.ts 1:0-63 3:15-25
@eclipse-che/dashboard-frontend: @ ./src/store/Workspaces/devWorkspaces/index.ts 9:0-55 143:21-35 636:16-30
@eclipse-che/dashboard-frontend: @ ./src/store/index.ts
@eclipse-che/dashboard-frontend: @ ./src/store/configureStore.ts 5:0-29 8:11-19
@eclipse-che/dashboard-frontend: @ ./src/index.tsx 10:0-52 14:18-32
@eclipse-che/dashboard-frontend: ERROR in ../../node_modules/@devfile/api/dist/index.js 7:0-47
@eclipse-che/dashboard-frontend: Module not found: Error: Can't resolve './apis/baseapi' in '/dashboard/node_modules/@devfile/api/dist'
@eclipse-che/dashboard-frontend: Did you mean 'baseapi.js'?
@eclipse-che/dashboard-frontend: BREAKING CHANGE: The request './apis/baseapi' failed to resolve only because it was resolved as fully specified
@eclipse-che/dashboard-frontend: (probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
@eclipse-che/dashboard-frontend: The extension in the request is mandatory for it to be fully specified.
@eclipse-che/dashboard-frontend: Add the extension to the request.
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/devfileApi.ts 1:0-80 1:0-80
@eclipse-che/dashboard-frontend: @ ./src/services/devfileApi/index.ts 1:0-63 3:15-25
@eclipse-che/dashboard-frontend: @ ./src/store/Workspaces/devWorkspaces/index.ts 9:0-55 143:21-35 636:16-30
@eclipse-che/dashboard-frontend: @ ./src/store/index.ts
@eclipse-che/dashboard-frontend: @ ./src/store/configureStore.ts 5:0-29 8:11-19
@eclipse-che/dashboard-frontend: @ ./src/index.tsx 10:0-52 14:18-32
@eclipse-che/dashboard-frontend: 7 errors have detailed information that is not shown.
@eclipse-che/dashboard-frontend: Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.
@eclipse-che/dashboard-frontend: webpack 5.89.0 compiled with 7 errors and 1 warning in 45295 ms
@eclipse-che/dashboard-frontend: @eclipse-che/dashboard-frontend: error Command failed with exit code 1.
@eclipse-che/dashboard-frontend: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Lerna (powered by Nx) Running target build for 2 projects failed
Failed tasks:

  • @eclipse-che/dashboard-frontend:build
    error Command failed with exit code 1.
    info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
    error: build error: building at STEP "RUN yarn build": while running runtime: exit status 1
    INFO[2023-12-13T16:56:06Z] Ran for 6m12s
    ERRO[2023-12-13T16:56:06Z] Some steps failed:
    ERRO[2023-12-13T16:56:06Z]
  • could not run steps: step che-dashboard-image failed: error occurred handling build che-dashboard-image-amd64: the build che-dashboard-image-amd64 failed after 3m1s with reason DockerBuildFailed: Dockerfile build strategy has failed.
    INFO[2023-12-13T16:56:06Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:building_project_image'

Could you please take a look?

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1021

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1021", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Dec 14, 2023
Copy link

openshift-ci bot commented Dec 14, 2023

New changes are detected. LGTM label has been removed.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1021

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1021", name: che-dashboard}]}}]"

@olexii4 olexii4 merged commit 192ea74 into main Dec 14, 2023
11 checks passed
@olexii4 olexii4 deleted the upgrade_libs branch December 14, 2023 13:31
@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/425: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/425: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5653 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.x/5654: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5525 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.x/2441: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5654 triggered

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2284: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1644: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.x/5228: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2441 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1644: SUCCESS

3.12.0-CI

@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/426: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/426: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5684 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.x/5263: UNSTABLE

No new images detected: nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants