-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to copy-paste SSH keys #1026
Conversation
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1026 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1026", name: che-dashboard}]}}]" |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
+ Coverage 87.99% 88.12% +0.12%
==========================================
Files 383 386 +3
Lines 39302 39633 +331
Branches 2606 2638 +32
==========================================
+ Hits 34585 34927 +342
+ Misses 4692 4681 -11
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1026 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1026", name: che-dashboard}]}}]" |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
...s/dashboard-frontend/src/pages/UserPreferences/SshKeys/AddModal/Form/SshPrivateKey/index.tsx
Outdated
Show resolved
Hide resolved
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1026 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1026", name: che-dashboard}]}}]" |
Build 3.12 :: dashboard_3.x/437: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5874: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/4114: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/5741: dashboard : 3.x :: Build 57944046 : quay.io/devspaces/dashboard-rhel8:3.12-16 |
Build 3.12 :: sync-to-downstream_3.x/5876: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/4115: Console, Changes, Git Data |
Build 3.12 :: copyIIBsToQuay/2377: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5876: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5743 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.12 :: operator-bundle_3.x/2524: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5876 triggered |
Build 3.12 :: update-digests_3.x/5497: Detected new images: rebuild operator-bundle |
Build 3.12 :: dsc_3.x/1721: Console, Changes, Git Data |
Build 3.12 :: dsc_3.x/1721: 3.12.0-CI |
Build 3.11 :: dashboard_3.11/4: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.11/56: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.11/50: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.11/55: dashboard : 3.11 :: Build 57947360 : quay.io/devspaces/dashboard-rhel8:3.11-45 |
Build 3.11 :: dashboard_3.11/4: Upstream sync done; /DS_CI/sync-to-downstream_3.11/56 triggered |
Build 3.11 :: update-digests_3.11/224: Console, Changes, Git Data |
Build 3.11 :: operator-bundle_3.11/28: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.11/63: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.11/54: Console, Changes, Git Data |
Build 3.11 :: copyIIBsToQuay/2378: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.11/63: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.11/62 triggered; /job/DS_CI/job/dsc_3.11 triggered; |
Build 3.11 :: operator-bundle_3.11/28: Upstream sync done; /DS_CI/sync-to-downstream_3.11/63 triggered |
Build 3.11 :: update-digests_3.11/224: Detected new images: rebuild operator-bundle |
Build 3.11 :: dsc_3.11/26: Console, Changes, Git Data |
Build 3.11 :: dsc_3.11/26: 3.11.0-CI |
What does this PR do?
This PR introduces the ability to copy-paste SSH keys.
Screen.Recording.2023-12-20.at.15.45.57.mov
What issues does this PR fix or reference?
resolves eclipse-che/che#22719