Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to copy-paste SSH keys #1026

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Allow to copy-paste SSH keys #1026

merged 4 commits into from
Jan 9, 2024

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Dec 19, 2023

What does this PR do?

This PR introduces the ability to copy-paste SSH keys.

Screen.Recording.2023-12-20.at.15.45.57.mov

What issues does this PR fix or reference?

resolves eclipse-che/che#22719

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy akurinnoy self-assigned this Dec 19, 2023
@che-bot
Copy link
Contributor

che-bot commented Dec 19, 2023

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1026

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1026", name: che-dashboard}]}}]"

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ce34226) 87.99% compared to head (6defc68) 88.12%.
Report is 9 commits behind head on main.

Files Patch % Lines
...nd/src/components/TextFileUpload/Preview/index.tsx 92.30% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   87.99%   88.12%   +0.12%     
==========================================
  Files         383      386       +3     
  Lines       39302    39633     +331     
  Branches     2606     2638      +32     
==========================================
+ Hits        34585    34927     +342     
+ Misses       4692     4681      -11     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1026

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1026", name: che-dashboard}]}}]"

@akurinnoy
Copy link
Contributor Author

/retest

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk ibuziuk requested a review from dmytro-ndp January 4, 2024 14:39
@openshift-ci openshift-ci bot removed the lgtm label Jan 9, 2024
Copy link

openshift-ci bot commented Jan 9, 2024

New changes are detected. LGTM label has been removed.

Copy link

github-actions bot commented Jan 9, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1026

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1026", name: che-dashboard}]}}]"

@ibuziuk ibuziuk merged commit 67ace78 into main Jan 9, 2024
17 checks passed
@ibuziuk ibuziuk deleted the copy-paste-ssh-keys branch January 9, 2024 17:11
@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/437: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2377: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.x/5876: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5743 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.x/2524: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5876 triggered

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.x/5497: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2524 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1721: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1721: SUCCESS

3.12.0-CI

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2377: SUCCESS

3.12
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.12-83
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-645735-s390x
  + quay.io/devspaces/iib:3.12-v4.15-s390x
  + quay.io/devspaces/iib:next-v4.15-s390x
  + quay.io/devspaces/iib:3.12-v4.14-645731-533291-s390x
  + quay.io/devspaces/iib:3.12-v4.13-645725-533286-s390x
  + quay.io/devspaces/iib:3.12-v4.12-645747-533281-s390x
  + quay.io/devspaces/iib:3.12-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-645735-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-645731-533291-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-645750-533286-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-645747-533281-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-645735-ppc64le
  + quay.io/devspaces/iib:3.12-v4.15-ppc64le
  + quay.io/devspaces/iib:next-v4.15-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-645731-533291-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-645750-533286-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-645747-533281-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.11/4: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.11/4: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.11/56 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2378: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.11/63: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.11/62 triggered; /job/DS_CI/job/dsc_3.11 triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.11/28: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.11/63 triggered

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.11/224: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.11/28 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.11/26: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: dsc_3.11/26: SUCCESS

3.11.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to copy / paste the SSH Keys
6 participants