-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the gitconfig page #1031
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1031 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1031", name: che-dashboard}]}}]" |
/retest |
Verified on Eclipse Che with |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 88.13% 88.16% +0.02%
==========================================
Files 386 387 +1
Lines 39635 39728 +93
Branches 2641 2651 +10
==========================================
+ Hits 34934 35026 +92
- Misses 4676 4677 +1
Partials 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1031 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1031", name: che-dashboard}]}}]" |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.12 :: dashboard_3.x/440: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5942: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/4156: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/5807: dashboard : 3.x :: Build 58076527 : quay.io/devspaces/dashboard-rhel8:3.12-18 |
Build 3.12 :: update-digests_3.x/5556: Console, Changes, Git Data |
Build 3.12 :: dashboard_3.x/440: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5942 triggered |
Build 3.12 :: operator-bundle_3.x/2541: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5943: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/4157: Console, Changes, Git Data |
Build 3.12 :: copyIIBsToQuay/2405: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5943: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5808 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.12 :: operator-bundle_3.x/2541: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5943 triggered |
Build 3.12 :: dsc_3.x/1738: Console, Changes, Git Data |
Build 3.12 :: update-digests_3.x/5556: Detected new images: rebuild operator-bundle |
Build 3.12 :: dsc_3.x/1738: 3.12.0-CI |
What does this PR do?
This PR improves the Gitcofig page to make it possible to update the user name and user email at the same time.
Screencast
Screen.Recording.2024-01-10.at.12.49.55.mov
What issues does this PR fix or reference?
resolves eclipse-che/che#22718