Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the gitconfig page #1031

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Improve the gitconfig page #1031

merged 1 commit into from
Jan 15, 2024

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR improves the Gitcofig page to make it possible to update the user name and user email at the same time.

Screencast
Screen.Recording.2024-01-10.at.12.49.55.mov

What issues does this PR fix or reference?

resolves eclipse-che/che#22718

@akurinnoy akurinnoy self-assigned this Jan 10, 2024
@che-bot
Copy link
Contributor

che-bot commented Jan 10, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1031

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1031", name: che-dashboard}]}}]"

@akurinnoy
Copy link
Contributor Author

/retest

@ibuziuk ibuziuk requested a review from artaleks9 January 10, 2024 14:14
@artaleks9
Copy link
Contributor

Verified on Eclipse Che with quay.io/eclipse/che-dashboard:pr-1031 - the functionality works as expected.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ba7b93d) 88.13% compared to head (d2560d6) 88.16%.

Files Patch % Lines
...tend/src/pages/UserPreferences/GitConfig/index.tsx 86.48% 5 Missing ⚠️
...src/pages/UserPreferences/GitConfig/Form/index.tsx 96.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
+ Coverage   88.13%   88.16%   +0.02%     
==========================================
  Files         386      387       +1     
  Lines       39635    39728      +93     
  Branches     2641     2651      +10     
==========================================
+ Hits        34934    35026      +92     
- Misses       4676     4677       +1     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Oleksii Kurinnyi <[email protected]>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1031

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1031", name: che-dashboard}]}}]"

@akurinnoy
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk ibuziuk merged commit 1d8f39a into main Jan 15, 2024
17 checks passed
@ibuziuk ibuziuk deleted the gitconfig branch January 15, 2024 09:53
@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/440: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/440: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5942 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2405: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.x/5943: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5808 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.x/2541: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5943 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1738: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.x/5556: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2541 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1738: SUCCESS

3.12.0-CI

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2405: SUCCESS

3.12
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.12-100
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-648573-s390x
  + quay.io/devspaces/iib:3.12-v4.15-s390x
  + quay.io/devspaces/iib:next-v4.15-s390x
  + quay.io/devspaces/iib:3.12-v4.14-648570-533291-s390x
  + quay.io/devspaces/iib:3.12-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.12-v4.13-648569-533286-s390x
  + quay.io/devspaces/iib:3.12-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.12-v4.12-648568-533281-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-648573-x86_64
  + quay.io/devspaces/iib:3.12-v4.15-x86_64
  + quay.io/devspaces/iib:next-v4.15-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-648570-533291-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-648569-533286-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-648568-533281-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.15-648573-ppc64le
  + quay.io/devspaces/iib:3.12-v4.15-ppc64le
  + quay.io/devspaces/iib:next-v4.15-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-648570-533291-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-648569-533286-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-648568-533281-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not update email / username at the same time
6 participants