Set the editor content as an editor ID for custom editors #1038
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1038 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1038", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1038 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1038", name: che-dashboard}]}}]" |
olexii4
changed the title
|
/test v14-dashboard-happy-path |
|
@olexii4: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test v14-dashboard-happy-path |
|
Build 3.12 :: dashboard_3.x/442: Console, Changes, Git Data |
|
Build 3.12 :: sync-to-downstream_3.x/5961: Console, Changes, Git Data |
|
Build 3.12 :: push-latest-container-to-quay_3.x/4170: Console, Changes, Git Data |
|
Build 3.12 :: get-sources-rhpkg-container-build_3.x/5826: dashboard : 3.x :: Build 58112341 : quay.io/devspaces/dashboard-rhel8:3.12-20 |
|
Build 3.12 :: update-digests_3.x/5572: Console, Changes, Git Data |
|
Build 3.12 :: dashboard_3.x/442: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5961 triggered |
|
Build 3.12 :: operator-bundle_3.x/2549: Console, Changes, Git Data |
|
Build 3.12 :: sync-to-downstream_3.x/5963: Console, Changes, Git Data |
|
Build 3.12 :: push-latest-container-to-quay_3.x/4171: Console, Changes, Git Data |
|
Build 3.12 :: sync-to-downstream_3.x/5963: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5828 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.12 :: operator-bundle_3.x/2549: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5963 triggered |
|
Build 3.12 :: copyIIBsToQuay/2413: Console, Changes, Git Data |
|
Build 3.12 :: update-digests_3.x/5572: Detected new images: rebuild operator-bundle |
|
Build 3.12 :: dsc_3.x/1744: Console, Changes, Git Data |
|
Build 3.12 :: dsc_3.x/1744: 3.12.0-CI |
What does this PR do?
This PR fixed the problem with the wrong editor annotation for custom editors. It happens when we try to create a new workspace from the git repository with the custom editor in the
.chedirectory.For example:
Create a new workspace with the custom editor from the next link
{CHE-server}#https://github.com/olexii4/web-java-spring-boot.gitCheck created devworkspace attributes with swagger
{CHE-server}/dashboard/api/swaggerWe can see the wrong annotation
"che.eclipse.org/che-editor": "che-incubator/che-code/latest"for che-idea.What issues does this PR fix or reference?
Is it tested? How?
kubectl patch command
{CHE-server}#https://github.com/olexii4/web-java-spring-boot.git{CHE-server}/dashboard/api/swaggerWe can see the custom editor content as
che.eclipse.org/che-editorannotation.