-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cloning devfile object #1302
Conversation
Signed-off-by: Anatolii Bazko <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1302 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1302", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified using The functionality works properly. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.18 :: dashboard_3.18/12: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.18/361: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.18/49: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.18/369: dashboard : 3.18 :: Build 66479803 : quay.io/devspaces/dashboard-rhel9:3.18-10 |
Build 3.18 :: dashboard_3.18/12: Upstream sync done; /DS_CI/sync-to-downstream_3.18/361 triggered |
Build 3.18 :: update-digests_3.18/376: Console, Changes, Git Data |
Build 3.18 :: operator-bundle_3.18/303: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.18/362: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.18/50: Console, Changes, Git Data |
Build 3.18 :: copyIIBsToQuay/2904: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.18/362: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.18/370 triggered; /job/DS_CI/job/dsc_3.18 triggered; |
Build 3.18 :: operator-bundle_3.18/303: Upstream sync done; /DS_CI/sync-to-downstream_3.18/362 triggered |
Build 3.18 :: dsc_3.18/16: Console, Changes, Git Data |
Build 3.18 :: update-digests_3.18/376: Detected new images: rebuild operator-bundle |
Build 3.18 :: dsc_3.18/16: 3.18.0-CI |
Build 3.18 :: copyIIBsToQuay/2905: Console, Changes, Git Data |
What does this PR do?
Cloning devfile object
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-7924
Is it tested? How?
TODO
Release Notes
Docs PR